From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: add missing permission check for request_key() destination
Date: Tue, 28 Nov 2017 10:13:01 +0000 [thread overview]
Message-ID: <7849.1511863981@warthog.procyon.org.uk> (raw)
In-Reply-To: <20171120225830.96642-1-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> + if (do_perm_check) {
> + ret = key_permission(make_key_ref(dest_keyring, 1),
> + KEY_NEED_WRITE);
dest_keyring may be NULL at this point as alloc_uid() doesn't automatically
create keyrings.
David
next prev parent reply other threads:[~2017-11-28 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 22:58 Eric Biggers
2017-11-28 10:13 ` David Howells [this message]
2017-11-28 19:06 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7849.1511863981@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome