* [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data
@ 2024-05-01 11:28 Christophe JAILLET
2024-05-02 8:01 ` Gerald Loacker
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-05-01 11:28 UTC (permalink / raw)
To: Gerald Loacker, Jonathan Cameron, Lars-Peter Clausen
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-iio
In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
Remove them.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
It was added in the initial commit 866a1389174b ("iio: magnetometer: add
ti tmag5273 driver") but was never used.
---
drivers/iio/magnetometer/tmag5273.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
index 218b1ce076c1..4187abe12784 100644
--- a/drivers/iio/magnetometer/tmag5273.c
+++ b/drivers/iio/magnetometer/tmag5273.c
@@ -118,11 +118,9 @@ struct tmag5273_data {
unsigned int version;
char name[16];
unsigned int conv_avg;
- unsigned int scale;
enum tmag5273_scale_index scale_index;
unsigned int angle_measurement;
struct regmap *map;
- struct regulator *vcc;
/*
* Locks the sensor for exclusive use during a measurement (which
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data
2024-05-01 11:28 [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data Christophe JAILLET
@ 2024-05-02 8:01 ` Gerald Loacker
0 siblings, 0 replies; 2+ messages in thread
From: Gerald Loacker @ 2024-05-02 8:01 UTC (permalink / raw)
To: Christophe JAILLET, Jonathan Cameron, Lars-Peter Clausen
Cc: linux-kernel, kernel-janitors, linux-iio
Hi Christophe,
Am 01.05.2024 um 13:28 schrieb Christophe JAILLET:
> In "struct tmag5273_data", the 'scale' and 'vcc' fields are unused.
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> It was added in the initial commit 866a1389174b ("iio: magnetometer: add
> ti tmag5273 driver") but was never used.
> ---
> drivers/iio/magnetometer/tmag5273.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
> index 218b1ce076c1..4187abe12784 100644
> --- a/drivers/iio/magnetometer/tmag5273.c
> +++ b/drivers/iio/magnetometer/tmag5273.c
> @@ -118,11 +118,9 @@ struct tmag5273_data {
> unsigned int version;
> char name[16];
> unsigned int conv_avg;
> - unsigned int scale;
> enum tmag5273_scale_index scale_index;
> unsigned int angle_measurement;
> struct regmap *map;
> - struct regulator *vcc;
>
> /*
> * Locks the sensor for exclusive use during a measurement (which
Thanks for cleaning up.
Reviewed-by: Gerald Loacker <gerald.loacker@wolfvision.net>
Regards,
Gerald
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-02 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-01 11:28 [PATCH] iio: tmag5273: Remove some unused field in struct tmag5273_data Christophe JAILLET
2024-05-02 8:01 ` Gerald Loacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®