mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Albert Cahalan" <acahalan@gmail.com>
To: linux-kernel@vger.kernel.org, ltuikov@yahoo.com
Subject: Re: [PATCH] sched.h: increment TASK_COMM_LEN to 20 bytes
Date: Fri, 23 Jun 2006 22:27:12 -0400	[thread overview]
Message-ID: <787b0d920606231927j67eb42a6k865391c75dbfd086@mail.gmail.com> (raw)

Luben Tuikov writes:

> Lets use 19+1 chars.  This helps display properly
> kernel threads (e.g. SATA translation threads) which bear
> the address of the STP/SATA bridge where the SATA disk is
> connected. Those are 16+1 chars long.  Currently (15+1) the
> last character is not displayed as it is used by the '\0'.

This makes apps crash when they do this:

char buf[16];
prctl(PR_GET_NAME, buf, 42, 42, 42);

Check the last 15 lines of kernel/sys.c to see why.

Though none of my code breaks, I have to wonder about what might
be out there. (my code truncates it)

I tend to think that putting 64 bits of hex in the command name
is an abuse of the command name. Perhaps it is time to make argv
work for built-in kernel tasks. It's also long past time to group
these things by tgid, reducing the horrible clutter seen on
large systems.

As for the size chosen...

Solaris uses 15. (plus 80 for unswappable argv)
Darwin uses 16. (was 10 I believe)
OpenBSD uses 16.
NetBSD uses 16.
We use 15. (you propose 19)
FreeBSD uses 19.

             reply	other threads:[~2006-06-24  2:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-24  2:27 Albert Cahalan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-07-01  1:06 Luben Tuikov
2006-07-01  1:19 ` Andrew Morton
2006-07-01  1:26   ` Luben Tuikov
2006-07-01  1:37     ` Andrew Morton
2006-07-01  2:48       ` Luben Tuikov
2006-07-01  4:46       ` Jeff Garzik
2006-07-01  4:53         ` Andrew Morton
2006-07-07 17:00           ` Luben Tuikov
2006-07-07 17:10             ` Jeff Garzik
2006-07-09  0:48               ` Luben Tuikov
2006-07-01  9:01       ` Jan Engelhardt
2006-07-03 12:07   ` Jan Engelhardt
2006-06-23 16:49 Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=787b0d920606231927j67eb42a6k865391c75dbfd086@mail.gmail.com \
    --to=acahalan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltuikov@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®