From: Andrew Price <anprice@redhat.com>
To: Chaohai Chen <wdhh6@aliyun.com>, agruenba@redhat.com
Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: gfs: Delete duplicate function generic_update_time calls
Date: Wed, 16 Apr 2025 12:09:07 +0100 [thread overview]
Message-ID: <78895df2-fb5a-4dd9-849e-91930419fac1@redhat.com> (raw)
In-Reply-To: <20250416094240.206847-1-wdhh6@aliyun.com>
On 16/04/2025 10:42, Chaohai Chen wrote:
> generic_update_time is called by inode_update_time after
> processing gfs2_update_time function,
This is incorrect. inode_update_time() returns after calling
gfs2_update_time():
if (inode->i_op->update_time)
return inode->i_op->update_time(inode, flags);
generic_update_time(inode, flags);
Andy
> gfs2_update_time do not
> need call the generic_update_time again.
>
> Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
> ---
> fs/gfs2/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 6fbbaaad1cd0..05fc363bd6e7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -2171,7 +2171,6 @@ static int gfs2_update_time(struct inode *inode, int flags)
> if (error)
> return error;
> }
> - generic_update_time(inode, flags);
> return 0;
> }
>
prev parent reply other threads:[~2025-04-16 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 9:42 Chaohai Chen
2025-04-16 11:09 ` Andrew Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78895df2-fb5a-4dd9-849e-91930419fac1@redhat.com \
--to=anprice@redhat.com \
--cc=agruenba@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=wdhh6@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®