* [PATCH] fs: gfs: Delete duplicate function generic_update_time calls
@ 2025-04-16 9:42 Chaohai Chen
2025-04-16 11:09 ` Andrew Price
0 siblings, 1 reply; 2+ messages in thread
From: Chaohai Chen @ 2025-04-16 9:42 UTC (permalink / raw)
To: agruenba; +Cc: gfs2, linux-kernel, Chaohai Chen
generic_update_time is called by inode_update_time after
processing gfs2_update_time function, gfs2_update_time do not
need call the generic_update_time again.
Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
---
fs/gfs2/inode.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 6fbbaaad1cd0..05fc363bd6e7 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -2171,7 +2171,6 @@ static int gfs2_update_time(struct inode *inode, int flags)
if (error)
return error;
}
- generic_update_time(inode, flags);
return 0;
}
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: gfs: Delete duplicate function generic_update_time calls
2025-04-16 9:42 [PATCH] fs: gfs: Delete duplicate function generic_update_time calls Chaohai Chen
@ 2025-04-16 11:09 ` Andrew Price
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Price @ 2025-04-16 11:09 UTC (permalink / raw)
To: Chaohai Chen, agruenba; +Cc: gfs2, linux-kernel
On 16/04/2025 10:42, Chaohai Chen wrote:
> generic_update_time is called by inode_update_time after
> processing gfs2_update_time function,
This is incorrect. inode_update_time() returns after calling
gfs2_update_time():
if (inode->i_op->update_time)
return inode->i_op->update_time(inode, flags);
generic_update_time(inode, flags);
Andy
> gfs2_update_time do not
> need call the generic_update_time again.
>
> Signed-off-by: Chaohai Chen <wdhh6@aliyun.com>
> ---
> fs/gfs2/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 6fbbaaad1cd0..05fc363bd6e7 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -2171,7 +2171,6 @@ static int gfs2_update_time(struct inode *inode, int flags)
> if (error)
> return error;
> }
> - generic_update_time(inode, flags);
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-16 11:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-16 9:42 [PATCH] fs: gfs: Delete duplicate function generic_update_time calls Chaohai Chen
2025-04-16 11:09 ` Andrew Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®