* [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally
@ 2021-03-16 13:38 Geert Uytterhoeven
2021-03-16 13:46 ` Rafał Miłecki
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 13:38 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Florian Fainelli,
Rafał Miłecki
Cc: bcm-kernel-feedback-list, netdev, linux-kernel, Geert Uytterhoeven
Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, drop the automatic enabling of BCM4908_ENET.
Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Feel free to change to "default y if ARCH_BCM4908" and
To fix this, restrict the automatic enabling of BCM4908_ENET to
ARCH_BCM4908.
if you think BCM4908 SoCs cannot be used without enabling this.
---
drivers/net/ethernet/broadcom/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index f8a168b73307c03b..57bac60ba2b190d2 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -54,7 +54,6 @@ config B44_PCI
config BCM4908_ENET
tristate "Broadcom BCM4908 internal mac support"
depends on ARCH_BCM4908 || COMPILE_TEST
- default y
help
This driver supports Ethernet controller integrated into Broadcom
BCM4908 family SoCs.
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally
2021-03-16 13:38 [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
@ 2021-03-16 13:46 ` Rafał Miłecki
0 siblings, 0 replies; 2+ messages in thread
From: Rafał Miłecki @ 2021-03-16 13:46 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: David S . Miller, Jakub Kicinski, Florian Fainelli,
bcm-kernel-feedback-list, netdev, linux-kernel
On 2021-03-16 14:38, Geert Uytterhoeven wrote:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, drop the automatic enabling of BCM4908_ENET.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Feel free to change to "default y if ARCH_BCM4908" and
>
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> if you think BCM4908 SoCs cannot be used without enabling this.
Yes, please make it
default y if ARCH_BCM4908
instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-16 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 13:38 [PATCH] net: broadcom: BCM4908_ENET should not default to y, unconditionally Geert Uytterhoeven
2021-03-16 13:46 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®