* [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration
@ 2021-03-25 11:10 Wan Jiabing
2021-03-25 13:05 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Wan Jiabing @ 2021-03-25 11:10 UTC (permalink / raw)
To: Tomi Valkeinen, David Airlie, Daniel Vetter, Sebastian Reichel,
Laurent Pinchart, Wan Jiabing, Jyri Sarha, dri-devel,
linux-kernel
Cc: kael_w
struct dss_device has been declared. Remove the duplicate.
And sort these forward declarations alphabetically.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Sort forward declarations alphabetically.
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index a40abeafd2e9..040d5a3e33d6 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -48,16 +48,15 @@
#define DISPC_IRQ_ACBIAS_COUNT_STAT3 (1 << 29)
#define DISPC_IRQ_FRAMEDONE3 (1 << 30)
-struct dss_device;
-struct omap_drm_private;
-struct omap_dss_device;
struct dispc_device;
+struct drm_connector;
struct dss_device;
struct dss_lcd_mgr_config;
+struct hdmi_avi_infoframe;
+struct omap_drm_private;
+struct omap_dss_device;
struct snd_aes_iec958;
struct snd_cea_861_aud_if;
-struct hdmi_avi_infoframe;
-struct drm_connector;
enum omap_display_type {
OMAP_DISPLAY_TYPE_NONE = 0,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration
2021-03-25 11:10 [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration Wan Jiabing
@ 2021-03-25 13:05 ` Laurent Pinchart
2021-03-26 7:24 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2021-03-25 13:05 UTC (permalink / raw)
To: Wan Jiabing
Cc: Tomi Valkeinen, David Airlie, Daniel Vetter, Sebastian Reichel,
Jyri Sarha, dri-devel, linux-kernel, kael_w
Hi Wan,
Thank you for the patch.
On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared. Remove the duplicate.
> And sort these forward declarations alphabetically.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tomi, I assume you'll handle this patch, please let me know if you don't
plan to do so.
> ---
> Changelog:
> v2:
> - Sort forward declarations alphabetically.
> ---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..040d5a3e33d6 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -48,16 +48,15 @@
> #define DISPC_IRQ_ACBIAS_COUNT_STAT3 (1 << 29)
> #define DISPC_IRQ_FRAMEDONE3 (1 << 30)
>
> -struct dss_device;
> -struct omap_drm_private;
> -struct omap_dss_device;
> struct dispc_device;
> +struct drm_connector;
> struct dss_device;
> struct dss_lcd_mgr_config;
> +struct hdmi_avi_infoframe;
> +struct omap_drm_private;
> +struct omap_dss_device;
> struct snd_aes_iec958;
> struct snd_cea_861_aud_if;
> -struct hdmi_avi_infoframe;
> -struct drm_connector;
>
> enum omap_display_type {
> OMAP_DISPLAY_TYPE_NONE = 0,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration
2021-03-25 13:05 ` Laurent Pinchart
@ 2021-03-26 7:24 ` Tomi Valkeinen
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2021-03-26 7:24 UTC (permalink / raw)
To: Laurent Pinchart, Wan Jiabing
Cc: David Airlie, Daniel Vetter, Sebastian Reichel, Jyri Sarha,
dri-devel, linux-kernel, kael_w
On 25/03/2021 15:05, Laurent Pinchart wrote:
> Hi Wan,
>
> Thank you for the patch.
>
> On Thu, Mar 25, 2021 at 07:10:24PM +0800, Wan Jiabing wrote:
>> struct dss_device has been declared. Remove the duplicate.
>> And sort these forward declarations alphabetically.
>>
>> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Tomi, I assume you'll handle this patch, please let me know if you don't
> plan to do so.
Yep, picked this up. Thanks!
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-26 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 11:10 [PATCH] [v2] drivers: gpu: drm: Remove duplicate declaration Wan Jiabing
2021-03-25 13:05 ` Laurent Pinchart
2021-03-26 7:24 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®