* [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup()
@ 2025-02-12 15:23 Dan Carpenter
2025-02-12 20:59 ` Dmitry Baryshkov
2025-02-13 8:56 ` Maxime Ripard
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2025-02-12 15:23 UTC (permalink / raw)
To: Louis Chauvet
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel,
kernel-janitors
The drm_writeback_cleanup_job() function frees "pos" so call
list_del(&pos->list_entry) first to avoid a use after free.
Fixes: 1914ba2b91ea ("drm: writeback: Create drmm variants for drm_writeback_connector initialization")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/drm_writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index 3628fbef7752..f139b49af4c9 100644
--- a/drivers/gpu/drm/drm_writeback.c
+++ b/drivers/gpu/drm/drm_writeback.c
@@ -360,8 +360,8 @@ static void drm_writeback_connector_cleanup(struct drm_device *dev,
spin_lock_irqsave(&wb_connector->job_lock, flags);
list_for_each_entry_safe(pos, n, &wb_connector->job_queue, list_entry) {
- drm_writeback_cleanup_job(pos);
list_del(&pos->list_entry);
+ drm_writeback_cleanup_job(pos);
}
spin_unlock_irqrestore(&wb_connector->job_lock, flags);
}
--
2.47.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup()
2025-02-12 15:23 [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup() Dan Carpenter
@ 2025-02-12 20:59 ` Dmitry Baryshkov
2025-02-13 8:56 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-02-12 20:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Louis Chauvet, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel, kernel-janitors
On Wed, Feb 12, 2025 at 06:23:48PM +0300, Dan Carpenter wrote:
> The drm_writeback_cleanup_job() function frees "pos" so call
> list_del(&pos->list_entry) first to avoid a use after free.
>
> Fixes: 1914ba2b91ea ("drm: writeback: Create drmm variants for drm_writeback_connector initialization")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/drm_writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup()
2025-02-12 15:23 [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup() Dan Carpenter
2025-02-12 20:59 ` Dmitry Baryshkov
@ 2025-02-13 8:56 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2025-02-13 8:56 UTC (permalink / raw)
To: Louis Chauvet, Dan Carpenter
Cc: Maxime Ripard, Maarten Lankhorst, Thomas Zimmermann,
David Airlie, Simona Vetter, dri-devel, linux-kernel,
kernel-janitors
On Wed, 12 Feb 2025 18:23:48 +0300, Dan Carpenter wrote:
> The drm_writeback_cleanup_job() function frees "pos" so call
> list_del(&pos->list_entry) first to avoid a use after free.
>
>
Applied to misc/kernel.git (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-13 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-12 15:23 [PATCH next] drm: writeback: Fix use after free in drm_writeback_connector_cleanup() Dan Carpenter
2025-02-12 20:59 ` Dmitry Baryshkov
2025-02-13 8:56 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®