From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
mtosatti@redhat.com, paulmck@kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH] tracing/osnoise: Force quiescent states while tracing
Date: Fri, 4 Mar 2022 15:28:54 +0100 [thread overview]
Message-ID: <78d798aa-388c-70bc-4227-985ba76c1d7e@kernel.org> (raw)
In-Reply-To: <20220228141423.259691-1-nsaenzju@redhat.com>
On 2/28/22 15:14, Nicolas Saenz Julienne wrote:
> At the moment running osnoise on an isolated CPU and a PREEMPT_RCU
> kernel might have the side effect of extending grace periods too much.
> This will eventually entice RCU to schedule a task on the isolated CPU
> to end the overly extended grace period, adding unwarranted noise to the
> CPU being traced in the process.
>
> So, check if we're the only ones running on this isolated CPU and that
> we're on a PREEMPT_RCU setup. If so, let's force quiescent states in
> between measurements.
>
> Non-PREEMPT_RCU setups don't need to worry about this as osnoise main
> loop's cond_resched() will go though a quiescent state for them.
>
> Note that this same exact problem is what extended quiescent states were
> created for. But adapting them to this specific use-case isn't trivial
> as it'll imply reworking entry/exit and dynticks/context tracking code.
Hey Nicolas,
While testing this patch with rtla osnoise on the 5.17.0-rc6-rt10+, when I hit
^c on osnoise top, the system freezes :-/.
Could you try that on your system?
-- Daniel
next prev parent reply other threads:[~2022-03-04 14:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 14:14 Nicolas Saenz Julienne
2022-02-28 15:45 ` Steven Rostedt
2022-03-01 10:59 ` Nicolas Saenz Julienne
2022-03-01 17:30 ` Daniel Bristot de Oliveira
2022-02-28 20:00 ` Daniel Bristot de Oliveira
2022-03-01 10:52 ` Nicolas Saenz Julienne
2022-03-01 17:55 ` Daniel Bristot de Oliveira
2022-03-01 18:05 ` Paul E. McKenney
2022-03-01 18:44 ` Daniel Bristot de Oliveira
2022-03-01 18:58 ` Paul E. McKenney
2022-03-01 19:29 ` Daniel Bristot de Oliveira
2022-03-01 19:46 ` Paul E. McKenney
2022-03-01 19:53 ` Daniel Bristot de Oliveira
2022-02-28 22:11 ` Paul E. McKenney
2022-03-01 10:00 ` Nicolas Saenz Julienne
2022-03-01 17:44 ` Daniel Bristot de Oliveira
2022-03-01 17:56 ` Paul E. McKenney
2022-03-02 10:46 ` Nicolas Saenz Julienne
2022-03-04 14:28 ` Daniel Bristot de Oliveira [this message]
2022-03-04 14:36 ` Nicolas Saenz Julienne
2022-03-04 14:39 ` Daniel Bristot de Oliveira
2022-03-04 14:51 ` Daniel Bristot de Oliveira
2022-03-04 15:28 ` Nicolas Saenz Julienne
2022-03-04 15:37 ` Daniel Bristot de Oliveira
2022-03-04 15:55 ` Nicolas Saenz Julienne
2022-03-04 16:26 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d798aa-388c-70bc-4227-985ba76c1d7e@kernel.org \
--to=bristot@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome