From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
agross@kernel.org, andersson@kernel.org, djakov@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
benl@squareup.com, shawn.guo@linaro.org,
fabien.parent@linaro.org, leo.yan@linaro.org,
dmitry.baryshkov@linaro.org, stephan@gerhold.net,
Jun Nie <jun.nie@linaro.org>,
James Willcox <jwillcox@squareup.com>,
Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
Zac Crosby <zac@squareup.com>,
Vincent Knecht <vincent.knecht@mailoo.org>
Subject: Re: [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC
Date: Thu, 23 Feb 2023 13:53:58 +0100 [thread overview]
Message-ID: <78f9f327-283d-c7f9-b54b-a54efd1d264b@linaro.org> (raw)
In-Reply-To: <f852bf35-6f29-a91a-00ab-9f7b2d709328@linaro.org>
On 23.02.2023 13:51, Bryan O'Donoghue wrote:
> On 22/02/2023 17:08, Konrad Dybcio wrote:
>>> + interrupt-names = "wdog", "fatal", "ready",
>>> + "handover", "stop-ack";
>> This should be a vertical list
>>
>>> +
>>> + clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>>> + <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>,
>>> + <&gcc GCC_BOOT_ROM_AHB_CLK>,
>>> + <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>> + clock-names = "iface", "bus", "mem", "xo";
>> This could also be one
>>
>
> Sorry what are you asking for here Konrad
>
> clock-names = "iface",
> "bus",
>
> if so, why ?
Yep!
It's just easier to read.. you don't have to count the
nth entry in a single line. Maybe this specific example
is still easy for the human brain to quickly cross-reference,
longer lists or lists with longer entries than 3 or so are
confusing..
Konrad
next prev parent reply other threads:[~2023-02-23 12:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 12:04 [PATCH v6 0/5] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-02-22 12:04 ` [PATCH v6 1/5] dt-bindings: vendor-prefixes: Add Square Bryan O'Donoghue
2023-02-22 12:04 ` [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-02-22 17:08 ` Konrad Dybcio
2023-02-23 12:51 ` Bryan O'Donoghue
2023-02-23 12:53 ` Konrad Dybcio [this message]
2023-02-23 13:02 ` Bryan O'Donoghue
2023-02-23 13:53 ` Konrad Dybcio
2023-02-22 12:04 ` [PATCH v6 3/5] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-02-22 17:18 ` Konrad Dybcio
2023-02-22 17:20 ` Bryan O'Donoghue
2023-02-22 12:04 ` [PATCH v6 4/5] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-02-22 12:04 ` [PATCH v6 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78f9f327-283d-c7f9-b54b-a54efd1d264b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
--cc=vincent.knecht@mailoo.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®