Re: [PATCH v6 2/5] arm64: dts: qcom: Add msm8939 SoC

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 23/02/2023 12:53, Konrad Dybcio wrote:
> 
> 
> On 23.02.2023 13:51, Bryan O'Donoghue wrote:
>> On 22/02/2023 17:08, Konrad Dybcio wrote:
>>>> +            interrupt-names = "wdog", "fatal", "ready",
>>>> +                      "handover", "stop-ack";
>>> This should be a vertical list
>>>
>>>> +
>>>> +            clocks = <&gcc GCC_MSS_CFG_AHB_CLK>,
>>>> +                 <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>,
>>>> +                 <&gcc GCC_BOOT_ROM_AHB_CLK>,
>>>> +                 <&rpmcc RPM_SMD_XO_CLK_SRC>;
>>>> +            clock-names = "iface", "bus", "mem", "xo";
>>> This could also be one
>>>
>>
>> Sorry what are you asking for here Konrad
>>
>> clock-names = "iface",
>>                "bus",
>>
>> if so, why ?
> Yep!
> 
> It's just easier to read.. you don't have to count the
> nth entry in a single line. Maybe this specific example
> is still easy for the human brain to quickly cross-reference,
> longer lists or lists with longer entries than 3 or so are
> confusing..
> 
> Konrad

I'm not necessarily opposed to that, I just don't see much precedent for it.

But... fine.

---
bod