From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stanley Chang <stanley_chang@realtek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>, Ray Chi <raychi@google.com>,
Flavio Suligoi <f.suligoi@asem.it>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY
Date: Wed, 7 Jun 2023 13:54:42 +0200 [thread overview]
Message-ID: <79201bd6-6048-7013-aeb7-34d218139844@linaro.org> (raw)
In-Reply-To: <20230607062500.24669-2-stanley_chang@realtek.com>
On 07/06/2023 08:24, Stanley Chang wrote:
> Realtek DHC (digital home center) RTD SoCs support DWC3 XHCI USB
> controller. Added the driver to drive the USB 2.0 PHY transceivers.
>
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> ---
> v2 to v3 change:
> 1. Broken down into two patches, one for each of USB 2 & 3 PHY.
> 2. Removed parameter v1 support for simplification.
> 3. Use remove_new for driver remove callback.
...
> + platform_set_drvdata(pdev, rtk_phy);
> +
> + generic_phy = devm_phy_create(rtk_phy->dev, NULL, &ops);
> + if (IS_ERR(generic_phy))
> + return PTR_ERR(generic_phy);
> +
> + phy_set_drvdata(generic_phy, rtk_phy);
> +
> + phy_provider = devm_of_phy_provider_register(rtk_phy->dev,
> + of_phy_simple_xlate);
> + if (IS_ERR(phy_provider))
> + return PTR_ERR(phy_provider);
> +
> + ret = usb_add_phy_dev(&rtk_phy->phy);
> + if (ret)
> + goto err;
> +
> + create_debug_files(rtk_phy);
> +
> +err:
> + dev_dbg(dev, "Probe RTK USB 2.0 PHY (ret=%d)\n", ret);
I commented on your second patch, but everything is applicable here as
well. You have many useless debug messages. Many incorrect or useless
"if() return" which point to broken driver design (e.g. concurrent
access to half initialized structures where you substitute lack of
synchronization with incorrect "if() return"). Undocumented user
interface is one more big trouble.
I doubt you run checkpatch on this (be sure to run it with --strict and
fix almost everything).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-07 11:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:24 [PATCH v3 1/5] usb: phy: add usb phy notify port status API Stanley Chang
2023-06-07 6:24 ` [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 11:26 ` kernel test robot
2023-06-07 11:54 ` Krzysztof Kozlowski [this message]
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:00 ` Krzysztof Kozlowski
2023-06-08 7:15 ` Krzysztof Kozlowski
2023-06-07 17:31 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-08 6:55 ` Krzysztof Kozlowski
2023-06-08 7:07 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 3/5] phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 11:52 ` Krzysztof Kozlowski
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:21 ` Krzysztof Kozlowski
2023-06-08 7:40 ` Stanley Chang[昌育德]
2023-06-08 1:35 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 12:04 ` Krzysztof Kozlowski
2023-06-08 7:24 ` Stanley Chang[昌育德]
2023-06-08 7:49 ` Krzysztof Kozlowski
2023-06-08 8:21 ` Stanley Chang[昌育德]
2023-06-08 8:28 ` Krzysztof Kozlowski
2023-06-08 9:27 ` Stanley Chang[昌育德]
2023-06-08 7:47 ` Stanley Chang[昌育德]
2023-06-08 7:51 ` Krzysztof Kozlowski
2023-06-08 8:01 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 12:08 ` Krzysztof Kozlowski
2023-06-08 7:32 ` Stanley Chang[昌育德]
2023-06-08 7:50 ` Krzysztof Kozlowski
2023-06-08 8:00 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79201bd6-6048-7013-aeb7-34d218139844@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bagasdotme@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®