mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Ray Chi <raychi@google.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Matthias Kaehlcke <mka@chromium.org>,
	Flavio Suligoi <f.suligoi@asem.it>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY
Date: Thu, 8 Jun 2023 09:50:16 +0200	[thread overview]
Message-ID: <f06d9f97-591b-c76d-0313-49c1b7a1217e@linaro.org> (raw)
In-Reply-To: <1f13680401e449a3b9384710206cc2b0@realtek.com>

On 08/06/2023 09:32, Stanley Chang[昌育德] wrote:
>>> +examples:
>>> +  - |
>>> +    usb_port2_usb3phy: usb-phy@13e10 {
>>> +        compatible = "realtek,rtd1319d-usb3phy", "realtek,usb3phy";
>>> +        reg = <0x13e10 0x4>;
>>> +        #address-cells = <1>;
>>> +        #size-cells = <0>;
>>> +        #phy-cells = <0>;
>>> +
>>> +        phy@0 {
>>> +            reg = <0>;
>>> +            realtek,param =
>>> +                    <0x01 0xac8c>,
>>> +                    <0x06 0x0017>,
>>
>> First, this is matrix, not uint8 array. Second, 0xac8c is past 16 bits long, not 8.
>> Third, you put some magic register programming to DT.
>> Please don't. Drop all this from DT.
> 
> realtek,param is an uint32-matrx.
> I will revised the type.

Drop the property. It is not explained and not justified to be in DT.

Best regards,
Krzysztof


  reply	other threads:[~2023-06-08  7:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07  6:24 [PATCH v3 1/5] usb: phy: add usb phy notify port status API Stanley Chang
2023-06-07  6:24 ` [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 11:26   ` kernel test robot
2023-06-07 11:54   ` Krzysztof Kozlowski
2023-06-08  6:59     ` Stanley Chang[昌育德]
2023-06-08  7:00       ` Krzysztof Kozlowski
2023-06-08  7:15       ` Krzysztof Kozlowski
2023-06-07 17:31   ` kernel test robot
2023-06-08  2:18     ` Stanley Chang[昌育德]
2023-06-08  6:55       ` Krzysztof Kozlowski
2023-06-08  7:07         ` Stanley Chang[昌育德]
2023-06-07  6:24 ` [PATCH v3 3/5] phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 11:52   ` Krzysztof Kozlowski
2023-06-08  6:59     ` Stanley Chang[昌育德]
2023-06-08  7:21       ` Krzysztof Kozlowski
2023-06-08  7:40         ` Stanley Chang[昌育德]
2023-06-08  1:35   ` kernel test robot
2023-06-08  2:18     ` Stanley Chang[昌育德]
2023-06-07  6:24 ` [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 12:04   ` Krzysztof Kozlowski
2023-06-08  7:24     ` Stanley Chang[昌育德]
2023-06-08  7:49       ` Krzysztof Kozlowski
2023-06-08  8:21         ` Stanley Chang[昌育德]
2023-06-08  8:28           ` Krzysztof Kozlowski
2023-06-08  9:27             ` Stanley Chang[昌育德]
2023-06-08  7:47     ` Stanley Chang[昌育德]
2023-06-08  7:51       ` Krzysztof Kozlowski
2023-06-08  8:01         ` Stanley Chang[昌育德]
2023-06-07  6:24 ` [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 12:08   ` Krzysztof Kozlowski
2023-06-08  7:32     ` Stanley Chang[昌育德]
2023-06-08  7:50       ` Krzysztof Kozlowski [this message]
2023-06-08  8:00         ` Stanley Chang[昌育德]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f06d9f97-591b-c76d-0313-49c1b7a1217e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=f.suligoi@asem.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mka@chromium.org \
    --cc=raychi@google.com \
    --cc=robh+dt@kernel.org \
    --cc=stanley_chang@realtek.com \
    --cc=stern@rowland.harvard.edu \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®