* staging: fbtft: fb_upd161704: Replace udelay() with usleep_range()
@ 2026-10-24 15:32 Abubakar Musa Samaila
2026-10-24 23:35 ` Julia Lawall
2026-10-25 14:50 ` Andy Shevchenko
0 siblings, 2 replies; 4+ messages in thread
From: Abubakar Musa Samaila @ 2026-10-24 15:32 UTC (permalink / raw)
To: andy, gregkh, outreachy; +Cc: linux-staging, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
Hi Andy and Greg,
Please find attached the patch that replaces non-atomic udelay()
instances with appropriate usleep_range() bounds in
drivers/staging/fbtft/fb_upd161704.c.
Thanks,
Abubakar Musa Samaila
[-- Attachment #2: 0001-staging-fbtft-fb_upd161704-Replace-udelay-with-uslee.patch --]
[-- Type: application/octet-stream, Size: 2397 bytes --]
From 778030aa9291e3a7d40ffb03b19e6877041cddc8 Mon Sep 17 00:00:00 2001
From: Abubakar Musa Samaila <abubakarmusasamaila@gmail.com>
Date: Sat, 24 Oct 2026 12:02:25 +0100
Subject: [PATCH] staging: fbtft: fb_upd161704: Replace udelay() with
usleep_range()
Signed-off-by: Abubakar Musa Samaila <abubakarmusasamaila@gmail.com>
---
drivers/staging/fbtft/fb_upd161704.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fbtft/fb_upd161704.c b/drivers/staging/fbtft/fb_upd161704.c
index 7288140e7..94ae5bbf0 100644
--- a/drivers/staging/fbtft/fb_upd161704.c
+++ b/drivers/staging/fbtft/fb_upd161704.c
@@ -32,27 +32,27 @@ static int init_display(struct fbtft_par *par)
/* oscillator start */
write_reg(par, 0x003A, 0x0001); /*Oscillator 0: stop, 1: operation */
- udelay(100);
+ usleep_range(100, 150);
/* y-setting */
write_reg(par, 0x0024, 0x007B); /* amplitude setting */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0025, 0x003B); /* amplitude setting */
write_reg(par, 0x0026, 0x0034); /* amplitude setting */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0027, 0x0004); /* amplitude setting */
write_reg(par, 0x0052, 0x0025); /* circuit setting 1 */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0053, 0x0033); /* circuit setting 2 */
write_reg(par, 0x0061, 0x001C); /* adjustment V10 positive polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0062, 0x002C); /* adjustment V9 negative polarity */
write_reg(par, 0x0063, 0x0022); /* adjustment V34 positive polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0064, 0x0027); /* adjustment V31 negative polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0065, 0x0014); /* adjustment V61 negative polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0066, 0x0010); /* adjustment V61 negative polarity */
/* Basical clock for 1 line (BASECOUNT[7:0]) number specified */
@@ -60,7 +60,7 @@ static int init_display(struct fbtft_par *par)
/* Power supply setting */
write_reg(par, 0x0019, 0x0000); /* DC/DC output setting */
- udelay(200);
+ usleep_range(200, 250);
write_reg(par, 0x001A, 0x1000); /* DC/DC frequency setting */
write_reg(par, 0x001B, 0x0023); /* DC/DC rising setting */
write_reg(par, 0x001C, 0x0C01); /* Regulator voltage setting */
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: staging: fbtft: fb_upd161704: Replace udelay() with usleep_range()
2026-10-24 15:32 staging: fbtft: fb_upd161704: Replace udelay() with usleep_range() Abubakar Musa Samaila
@ 2026-10-24 23:35 ` Julia Lawall
2026-10-25 14:50 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2026-10-24 23:35 UTC (permalink / raw)
To: Abubakar Musa Samaila
Cc: andy, gregkh, outreachy, linux-staging, linux-fbdev, linux-kernel
On Sat, 24 Oct 2026, Abubakar Musa Samaila wrote:
> Hi Andy and Greg,
>
> Please find attached the patch that replaces non-atomic udelay()
> instances with appropriate usleep_range() bounds in
> drivers/staging/fbtft/fb_upd161704.c.
Hello,
Patches are not sent as attachments to the Linux kernel. Please read the
first patch tutorial again in its entirety and then try again. You can
also look at what others have done in the archives of the mailing list.
julia
>
> Thanks,
>
> Abubakar Musa Samaila
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: staging: fbtft: fb_upd161704: Replace udelay() with usleep_range()
2026-10-24 15:32 staging: fbtft: fb_upd161704: Replace udelay() with usleep_range() Abubakar Musa Samaila
2026-10-24 23:35 ` Julia Lawall
@ 2026-10-25 14:50 ` Andy Shevchenko
1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-10-25 14:50 UTC (permalink / raw)
To: Abubakar Musa Samaila
Cc: andy, gregkh, outreachy, linux-staging, linux-fbdev, linux-kernel
On Sat, Oct 24, 2026 at 04:32:11PM +0100, Abubakar Musa Samaila wrote:
> Hi Andy and Greg,
>
> Please find attached the patch that replaces non-atomic udelay()
> instances with appropriate usleep_range() bounds in
> drivers/staging/fbtft/fb_upd161704.c.
Please. study the respective mail archive on lore.kernel.org to understand
why this patch is no-go.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* staging: fbtft: fb_upd161704: Replace udelay() with usleep_range()
@ 2026-10-24 15:06 Abubakar Musa Samaila
0 siblings, 0 replies; 4+ messages in thread
From: Abubakar Musa Samaila @ 2026-10-24 15:06 UTC (permalink / raw)
To: andy, gregkh; +Cc: linux-staging, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
Hi Andy and Greg,
Please find attached the patch that replaces non-atomic udelay()
instances with appropriate usleep_range() bounds in
drivers/staging/fbtft/fb_upd161704.c.
Thanks,
Abubakar Musa Samaila
[-- Attachment #2: 0001-staging-fbtft-fb_upd161704-Replace-udelay-with-uslee.patch --]
[-- Type: application/octet-stream, Size: 2397 bytes --]
From 778030aa9291e3a7d40ffb03b19e6877041cddc8 Mon Sep 17 00:00:00 2001
From: Abubakar Musa Samaila <abubakarmusasamaila@gmail.com>
Date: Sat, 24 Oct 2026 12:02:25 +0100
Subject: [PATCH] staging: fbtft: fb_upd161704: Replace udelay() with
usleep_range()
Signed-off-by: Abubakar Musa Samaila <abubakarmusasamaila@gmail.com>
---
drivers/staging/fbtft/fb_upd161704.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fbtft/fb_upd161704.c b/drivers/staging/fbtft/fb_upd161704.c
index 7288140e7..94ae5bbf0 100644
--- a/drivers/staging/fbtft/fb_upd161704.c
+++ b/drivers/staging/fbtft/fb_upd161704.c
@@ -32,27 +32,27 @@ static int init_display(struct fbtft_par *par)
/* oscillator start */
write_reg(par, 0x003A, 0x0001); /*Oscillator 0: stop, 1: operation */
- udelay(100);
+ usleep_range(100, 150);
/* y-setting */
write_reg(par, 0x0024, 0x007B); /* amplitude setting */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0025, 0x003B); /* amplitude setting */
write_reg(par, 0x0026, 0x0034); /* amplitude setting */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0027, 0x0004); /* amplitude setting */
write_reg(par, 0x0052, 0x0025); /* circuit setting 1 */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0053, 0x0033); /* circuit setting 2 */
write_reg(par, 0x0061, 0x001C); /* adjustment V10 positive polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0062, 0x002C); /* adjustment V9 negative polarity */
write_reg(par, 0x0063, 0x0022); /* adjustment V34 positive polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0064, 0x0027); /* adjustment V31 negative polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0065, 0x0014); /* adjustment V61 negative polarity */
- udelay(10);
+ usleep_range(10, 20);
write_reg(par, 0x0066, 0x0010); /* adjustment V61 negative polarity */
/* Basical clock for 1 line (BASECOUNT[7:0]) number specified */
@@ -60,7 +60,7 @@ static int init_display(struct fbtft_par *par)
/* Power supply setting */
write_reg(par, 0x0019, 0x0000); /* DC/DC output setting */
- udelay(200);
+ usleep_range(200, 250);
write_reg(par, 0x001A, 0x1000); /* DC/DC frequency setting */
write_reg(par, 0x001B, 0x0023); /* DC/DC rising setting */
write_reg(par, 0x001C, 0x0C01); /* Regulator voltage setting */
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-25 14:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-24 15:32 staging: fbtft: fb_upd161704: Replace udelay() with usleep_range() Abubakar Musa Samaila
2026-10-24 23:35 ` Julia Lawall
2026-10-25 14:50 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2026-10-24 15:06 Abubakar Musa Samaila
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®