mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
@ 2025-10-23 18:00 David Heidelberg via B4 Relay
  2025-10-23 18:10 ` Krzysztof Kozlowski
  2025-10-24 23:27 ` Rob Herring (Arm)
  0 siblings, 2 replies; 3+ messages in thread
From: David Heidelberg via B4 Relay @ 2025-10-23 18:00 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-kernel, David Heidelberg

From: David Heidelberg <david@ixit.cz>

For better readability, it is recommended to insert a newline before the
'status' property. Adjust the examples accordingly.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/dts-coding-style.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
index 202acac0507ab..4a02ea60cbbe2 100644
--- a/Documentation/devicetree/bindings/dts-coding-style.rst
+++ b/Documentation/devicetree/bindings/dts-coding-style.rst
@@ -120,7 +120,8 @@ The following order of properties in device nodes is preferred:
 4. Standard/common properties (defined by common bindings, e.g. without
    vendor-prefixes)
 5. Vendor-specific properties
-6. "status" (if applicable)
+6. "status" (if applicable), preceded by a blank line if there is content
+   before the property
 7. Child nodes, where each node is preceded with a blank line
 
 The "status" property is by default "okay", thus it can be omitted.
@@ -150,6 +151,7 @@ Example::
 		#address-cells = <1>;
 		#size-cells = <1>;
 		vendor,custom-property = <2>;
+
 		status = "disabled";
 
 		child_node: child-class@100 {
@@ -165,6 +167,7 @@ Example::
 		vdd-1v8-supply = <&board_vreg4>;
 		vdd-3v3-supply = <&board_vreg2>;
 		vdd-12v-supply = <&board_vreg3>;
+
 		status = "okay";
 	}
 

---
base-commit: efb26a23ed5f5dc3554886ab398f559dcb1de96b
change-id: 20251023-docs-dt-newline-7e5eb43fe0fd

Best regards,
-- 
David Heidelberg <david@ixit.cz>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
  2025-10-23 18:00 [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status David Heidelberg via B4 Relay
@ 2025-10-23 18:10 ` Krzysztof Kozlowski
  2025-10-24 23:27 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-23 18:10 UTC (permalink / raw)
  To: david, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: devicetree, linux-kernel

On 23/10/2025 20:00, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> For better readability, it is recommended to insert a newline before the
> 'status' property. Adjust the examples accordingly.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status
  2025-10-23 18:00 [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status David Heidelberg via B4 Relay
  2025-10-23 18:10 ` Krzysztof Kozlowski
@ 2025-10-24 23:27 ` Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-10-24 23:27 UTC (permalink / raw)
  To: David Heidelberg
  Cc: linux-kernel, devicetree, Krzysztof Kozlowski, Conor Dooley


On Thu, 23 Oct 2025 20:00:02 +0200, David Heidelberg wrote:
> For better readability, it is recommended to insert a newline before the
> 'status' property. Adjust the examples accordingly.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  Documentation/devicetree/bindings/dts-coding-style.rst | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-24 23:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-23 18:00 [PATCH] docs: dt-bindings: Extend the ordering list with a blank newline before status David Heidelberg via B4 Relay
2025-10-23 18:10 ` Krzysztof Kozlowski
2025-10-24 23:27 ` Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®