* [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
@ 2024-08-22 20:50 Colin Ian King
2024-08-29 15:50 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2024-08-22 20:50 UTC (permalink / raw)
To: Thierry Reding, Mikko Perttunen, David Airlie, Daniel Vetter,
Jonathan Hunter, dri-devel, linux-tegra
Cc: kernel-janitors, linux-kernel
Don't populate the const read-only array possible_nvram_sizes on the
stack at run time, instead make it static.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/tegra/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 09987e372e3e..6bf2dae82ca0 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -434,7 +434,7 @@ tegra_hdmi_get_audio_config(unsigned int audio_freq, unsigned int pix_clock,
static void tegra_hdmi_setup_audio_fs_tables(struct tegra_hdmi *hdmi)
{
- const unsigned int freqs[] = {
+ static const unsigned int freqs[] = {
32000, 44100, 48000, 88200, 96000, 176400, 192000
};
unsigned int i;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
2024-08-22 20:50 [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static Colin Ian King
@ 2024-08-29 15:50 ` Thierry Reding
2024-08-29 15:51 ` Colin King (gmail)
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2024-08-29 15:50 UTC (permalink / raw)
To: Colin Ian King
Cc: Mikko Perttunen, David Airlie, Daniel Vetter, Jonathan Hunter,
dri-devel, linux-tegra, kernel-janitors, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 285 bytes --]
On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote:
> Don't populate the const read-only array possible_nvram_sizes on the
I've changed this (and the occurrence in the subject) to reflect the
actual array name ("freqs") that's being changed here.
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
2024-08-29 15:50 ` Thierry Reding
@ 2024-08-29 15:51 ` Colin King (gmail)
0 siblings, 0 replies; 3+ messages in thread
From: Colin King (gmail) @ 2024-08-29 15:51 UTC (permalink / raw)
To: Thierry Reding
Cc: Mikko Perttunen, David Airlie, Daniel Vetter, Jonathan Hunter,
dri-devel, linux-tegra, kernel-janitors, linux-kernel
On 29/08/2024 16:50, Thierry Reding wrote:
> On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote:
>> Don't populate the const read-only array possible_nvram_sizes on the
>
> I've changed this (and the occurrence in the subject) to reflect the
> actual array name ("freqs") that's being changed here.
Thanks, my bad.
Colin
>
> Applied, thanks.
>
> Thierry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-29 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-22 20:50 [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static Colin Ian King
2024-08-29 15:50 ` Thierry Reding
2024-08-29 15:51 ` Colin King (gmail)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®