mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zijun_hu <zijun_hu@zoho.com>
To: David Rientjes <rientjes@google.com>
Cc: zijun_hu@htc.com, Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org,
	mingo@kernel.org, iamjoonsoo.kim@lge.com,
	mgorman@techsingularity.net
Subject: Re: [PATCH 2/5] mm/vmalloc.c: simplify /proc/vmallocinfo implementation
Date: Thu, 22 Sep 2016 07:22:33 +0800	[thread overview]
Message-ID: <7961c13d-639a-25d7-ac0d-3dac2ebd7524@zoho.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1609211414200.20971@chino.kir.corp.google.com>

On 2016/9/22 5:16, David Rientjes wrote:
> On Wed, 21 Sep 2016, zijun_hu wrote:
> 
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index cc6ecd6..a125ae8 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -2576,32 +2576,13 @@ void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms)
>>  static void *s_start(struct seq_file *m, loff_t *pos)
>>  	__acquires(&vmap_area_lock)
>>  {
>> -	loff_t n = *pos;
>> -	struct vmap_area *va;
>> -
>>  	spin_lock(&vmap_area_lock);
>> -	va = list_first_entry(&vmap_area_list, typeof(*va), list);
>> -	while (n > 0 && &va->list != &vmap_area_list) {
>> -		n--;
>> -		va = list_next_entry(va, list);
>> -	}
>> -	if (!n && &va->list != &vmap_area_list)
>> -		return va;
>> -
>> -	return NULL;
>> -
>> +	return seq_list_start(&vmap_area_list, *pos);
>>  }
>>  
>>  static void *s_next(struct seq_file *m, void *p, loff_t *pos)
>>  {
>> -	struct vmap_area *va = p, *next;
>> -
>> -	++*pos;
>> -	next = list_next_entry(va, list);
>> -	if (&next->list != &vmap_area_list)
>> -		return next;
>> -
>> -	return NULL;
>> +	return seq_list_next(p, &vmap_area_list, pos);
>>  }
>>  
>>  static void s_stop(struct seq_file *m, void *p)
>> @@ -2636,9 +2617,11 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
>>  
>>  static int s_show(struct seq_file *m, void *p)
>>  {
>> -	struct vmap_area *va = p;
>> +	struct vmap_area *va;
>>  	struct vm_struct *v;
>>  
>> +	va = list_entry((struct list_head *)p, struct vmap_area, list);
> 
> Looks good other than no cast is neccessary above.
  you are right, it will correct it
  i refer to show_timer()@fs/proc/base.c plainly and ignore that redundant cast
> 
> The patches in this series seem to be unrelated to each other, they 
> shouldn't be numbered in order since there's no dependence.  Just 
> individual patches are fine.
> 
you are right, i will provide a individual patch finnally

      reply	other threads:[~2016-09-21 23:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21  4:26 zijun_hu
2016-09-21 21:16 ` David Rientjes
2016-09-21 23:22   ` zijun_hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7961c13d-639a-25d7-ac0d-3dac2ebd7524@zoho.com \
    --to=zijun_hu@zoho.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=rientjes@google.com \
    --cc=tj@kernel.org \
    --cc=zijun_hu@htc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®