* [PATCH] phy: Return NULL if the phy is optional
@ 2017-09-04 12:53 Maxime Ripard
2017-10-18 11:12 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 2+ messages in thread
From: Maxime Ripard @ 2017-09-04 12:53 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: linux-kernel, Maxime Ripard
If we're trying to get a handle to an optional phy, then the phy framework
being disabled shouldn't return an hard error.
Instead, return NULL just like phy_optional_get does when there's no phy
provided in the DT.
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
include/linux/phy/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 78bb0d7f6b11..76487b8d74ea 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -289,7 +289,7 @@ static inline struct phy *devm_phy_get(struct device *dev, const char *string)
static inline struct phy *devm_phy_optional_get(struct device *dev,
const char *string)
{
- return ERR_PTR(-ENOSYS);
+ return NULL;
}
static inline struct phy *devm_of_phy_get(struct device *dev,
--
2.13.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] phy: Return NULL if the phy is optional
2017-09-04 12:53 [PATCH] phy: Return NULL if the phy is optional Maxime Ripard
@ 2017-10-18 11:12 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2017-10-18 11:12 UTC (permalink / raw)
To: Maxime Ripard; +Cc: linux-kernel
On Monday 04 September 2017 06:23 PM, Maxime Ripard wrote:
> If we're trying to get a handle to an optional phy, then the phy framework
> being disabled shouldn't return an hard error.
>
> Instead, return NULL just like phy_optional_get does when there's no phy
> provided in the DT.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
merged, thanks!
-Kishon
> ---
> include/linux/phy/phy.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 78bb0d7f6b11..76487b8d74ea 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -289,7 +289,7 @@ static inline struct phy *devm_phy_get(struct device *dev, const char *string)
> static inline struct phy *devm_phy_optional_get(struct device *dev,
> const char *string)
> {
> - return ERR_PTR(-ENOSYS);
> + return NULL;
> }
>
> static inline struct phy *devm_of_phy_get(struct device *dev,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-18 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-04 12:53 [PATCH] phy: Return NULL if the phy is optional Maxime Ripard
2017-10-18 11:12 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®