mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bert Kenward <bkenward@solarflare.com>
To: Colin King <colin.king@canonical.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Edward Cree <ecree@solarflare.com>, <netdev@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: sfc: remove redundant variable start
Date: Thu, 9 Nov 2017 08:39:36 +0000	[thread overview]
Message-ID: <7992c6f6-f847-95b5-b16f-cbecdb05d439@solarflare.com> (raw)
In-Reply-To: <20171109080122.3254-1-colin.king@canonical.com>

On 09/11/17 08:01, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable start is assigned but never read hence it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/net/ethernet/sfc/ptp.c:655:2: warning: Value stored to 'start'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Bert Kenward <bkenward@solarflare.com>

Thanks Colin.

> ---
>  drivers/net/ethernet/sfc/ptp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 56c2db398def..caa89bf7603e 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -648,11 +648,9 @@ static void efx_ptp_send_times(struct efx_nic *efx,
>  	struct pps_event_time now;
>  	struct timespec64 limit;
>  	struct efx_ptp_data *ptp = efx->ptp_data;
> -	struct timespec64 start;
>  	int *mc_running = ptp->start.addr;
>  
>  	pps_get_ts(&now);
> -	start = now.ts_real;
>  	limit = now.ts_real;
>  	timespec64_add_ns(&limit, SYNCHRONISE_PERIOD_NS);
>  
> 

  reply	other threads:[~2017-11-09  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09  8:01 Colin King
2017-11-09  8:39 ` Bert Kenward [this message]
2017-11-11 10:14 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7992c6f6-f847-95b5-b16f-cbecdb05d439@solarflare.com \
    --to=bkenward@solarflare.com \
    --cc=colin.king@canonical.com \
    --cc=ecree@solarflare.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®