From: Rex-BC Chen <rex-bc.chen@mediatek.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<matthias.bgg@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kernel@collabora.com>
Subject: Re: [PATCH] soc: mediatek: mmsys: Add sw0_rst_offset for MT8192
Date: Wed, 23 Mar 2022 16:53:36 +0800 [thread overview]
Message-ID: <7992e5fcd0ed9fdee60ee9259b3238e33c86e28e.camel@mediatek.com> (raw)
In-Reply-To: <20220322092040.12010-1-angelogioacchino.delregno@collabora.com>
On Tue, 2022-03-22 at 10:20 +0100, AngeloGioacchino Del Regno wrote:
> MT8192 has the same sw0 reset offset as MT8183: add the parameter
> to be able to use mmsys as a reset controller for managing at
> least the DSI reset line.
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> ---
> drivers/soc/mediatek/mtk-mmsys.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-mmsys.c
> b/drivers/soc/mediatek/mtk-mmsys.c
> index 4fc4c2c9ea20..f69521fabcce 100644
> --- a/drivers/soc/mediatek/mtk-mmsys.c
> +++ b/drivers/soc/mediatek/mtk-mmsys.c
> @@ -70,6 +70,7 @@ static const struct mtk_mmsys_driver_data
> mt8192_mmsys_driver_data = {
> .clk_driver = "clk-mt8192-mm",
> .routes = mmsys_mt8192_routing_table,
> .num_routes = ARRAY_SIZE(mmsys_mt8192_routing_table),
> + .sw0_rst_offset = MT8183_MMSYS_SW0_RST_B,
> };
>
> static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data =
> {
Hello Angelo,
Thanks for your patch.
But from register map for mmsys, the offset is 0x160 and DSI reset bit
is 15.
datasheet: MT8192 Tablet Application Processor Software Register
Table/4.1 Display Controller.pdf
BRs,
Rex
prev parent reply other threads:[~2022-03-23 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 9:20 AngeloGioacchino Del Regno
2022-03-23 8:53 ` Rex-BC Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7992e5fcd0ed9fdee60ee9259b3238e33c86e28e.camel@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®