[PATCH v2 0/2] board: imx8mn-rve-gateway: fix compatible description

[PATCH v2 0/2] board: imx8mn-rve-gateway: fix compatible description

[Hugo Villeneuve]

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Hello,
this patch series fixes compatible description for the RVE gateway board.

Thank you.

Link: [v1] https://lore.kernel.org/all/20240124154422.3600920-1-hugo@hugovil.com/raw

Changes for V2:
-Add Fixes tags

Hugo Villeneuve (2):
  dt-bindings: arm: fsl: remove redundant company name
  arm64: dts: imx8mn-rve-gateway: remove redundant company name

 Documentation/devicetree/bindings/arm/fsl.yaml       | 2 +-
 arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


base-commit: 615d300648869c774bd1fe54b4627bb0c20faed4
-- 
2.39.2

[PATCH v2 1/2] dt-bindings: arm: fsl: remove redundant company name

[Hugo Villeneuve]

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Company name in compatible description appears twice, which is not really
helpful, so remove it from product name.

Fixes: bb405e8b5336 ("dt-bindings: arm: fsl: add RVE gateway board")
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 228dcc5c7d6f..f455c0172c84 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1026,7 +1026,7 @@ properties:
         items:
           - enum:
               - dimonoff,gateway-evk # i.MX8MN Dimonoff Gateway EVK Board
-              - rve,rve-gateway # i.MX8MN RVE Gateway Board
+              - rve,gateway # i.MX8MN RVE Gateway Board
               - variscite,var-som-mx8mn-symphony
           - const: variscite,var-som-mx8mn
           - const: fsl,imx8mn
-- 
2.39.2

Re: [PATCH v2 1/2] dt-bindings: arm: fsl: remove redundant company name

[Krzysztof Kozlowski]

On 24/01/2024 17:46, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> 
> Company name in compatible description appears twice, which is not really
> helpful, so remove it from product name.

It's just a string. There is no bug, at least you did not describe where
the bug is.

This has probably little impact on user-space, but there could be such
which actually reads compatibles and depends on them. Or bootloader or
whatever. Therefore to me such cosmetic change of correct compatible is
not worth ABI impact.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: fsl: remove redundant company name

[Hugo Villeneuve]

On Wed, 24 Jan 2024 18:00:00 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 24/01/2024 17:46, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Company name in compatible description appears twice, which is not really
> > helpful, so remove it from product name.
> 
> It's just a string. There is no bug, at least you did not describe where
> the bug is.

Hi Krzysztof,
in fact the fix is based on comments you made in a
review for another board that I submitted:

https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/

------------------
Company name appears twice, which is not really helpful. What's the true
name? Gateway EVK? Then keep only this.
-----------------

> This has probably little impact on user-space, but there could be such
> which actually reads compatibles and depends on them. Or bootloader or
> whatever. Therefore to me such cosmetic change of correct compatible is
> not worth ABI impact.

Yes, normally you would be right, but in this specific case, the board
is a prototype developped by my company and we are still at the
prototype stage, so there is zero ABI impact.

Maybe I can add this to the cover letter if you want me to submit a V3.

Hugo Villeneuve

Re: [PATCH v2 1/2] dt-bindings: arm: fsl: remove redundant company name

[Krzysztof Kozlowski]

On 24/01/2024 18:08, Hugo Villeneuve wrote:
> On Wed, 24 Jan 2024 18:00:00 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
>> On 24/01/2024 17:46, Hugo Villeneuve wrote:
>>> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>>>
>>> Company name in compatible description appears twice, which is not really
>>> helpful, so remove it from product name.
>>
>> It's just a string. There is no bug, at least you did not describe where
>> the bug is.
> 
> Hi Krzysztof,
> in fact the fix is based on comments you made in a
> review for another board that I submitted:
> 
> https://lore.kernel.org/all/6035c4cc-afe1-456d-a4d0-16992da09a2e@linaro.org/
> 
> ------------------
> Company name appears twice, which is not really helpful. What's the true
> name? Gateway EVK? Then keep only this.

You are mixing arguments. You want to change released compatible based
on style comment. Style comments are reasonable comments for compatibles
while they are patches. Not released commits.

> ----------------- 
> 
>> This has probably little impact on user-space, but there could be such
>> which actually reads compatibles and depends on them. Or bootloader or
>> whatever. Therefore to me such cosmetic change of correct compatible is
>> not worth ABI impact.
> 
> Yes, normally you would be right, but in this specific case, the board
> is a prototype developped by my company and we are still at the
> prototype stage, so there is zero ABI impact.
> 
> Maybe I can add this to the cover letter if you want me to submit a V3.

Any explanation and possible ABI impact should be in commit msg.

Anyway, one patchset per day, so people have chance to respond...

Best regards,
Krzysztof

[PATCH v2 2/2] arm64: dts: imx8mn-rve-gateway: remove redundant company name

[Hugo Villeneuve]

From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Company name in compatible description appears twice, which is not really
helpful, so remove it from product name.

Fixes: 67275c2f3d9b ("arm64: dts: freescale: introduce rve-gateway board")
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
 arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts b/arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts
index 1b633bd1ebb6..ea1855171fb0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-rve-gateway.dts
@@ -10,7 +10,7 @@
 
 / {
 	model = "RVE gateway";
-	compatible = "rve,rve-gateway", "variscite,var-som-mx8mn", "fsl,imx8mn";
+	compatible = "rve,gateway", "variscite,var-som-mx8mn", "fsl,imx8mn";
 
 	crystal_duart_24m: crystal-duart-24m {
 		compatible = "fixed-clock";
-- 
2.39.2