* [PATCH] ARM: oxnas: make ox820_boot_secondary static
@ 2020-05-12 1:46 Ma Feng
2020-05-12 8:24 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Ma Feng @ 2020-05-12 1:46 UTC (permalink / raw)
To: narmstrong, linux; +Cc: linux-arm-kernel, linux-oxnas, linux-kernel
Fix sparse warning:
arch/arm/mach-oxnas/platsmp.c:30:12: warning: symbol 'ox820_boot_secondary' was
not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
---
arch/arm/mach-oxnas/platsmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c
index ab35275..f0a50b9 100644
--- a/arch/arm/mach-oxnas/platsmp.c
+++ b/arch/arm/mach-oxnas/platsmp.c
@@ -27,7 +27,8 @@ static void __iomem *gic_cpu_ctrl;
#define GIC_CPU_CTRL 0x00
#define GIC_CPU_CTRL_ENABLE 1
-int __init ox820_boot_secondary(unsigned int cpu, struct task_struct *idle)
+static int __init ox820_boot_secondary(unsigned int cpu,
+ struct task_struct *idle)
{
/*
* Write the address of secondary startup into the
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: oxnas: make ox820_boot_secondary static
2020-05-12 1:46 [PATCH] ARM: oxnas: make ox820_boot_secondary static Ma Feng
@ 2020-05-12 8:24 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2020-05-12 8:24 UTC (permalink / raw)
To: Ma Feng, linux; +Cc: linux-arm-kernel, linux-oxnas, linux-kernel
On 12/05/2020 03:46, Ma Feng wrote:
> Fix sparse warning:
>
> arch/arm/mach-oxnas/platsmp.c:30:12: warning: symbol 'ox820_boot_secondary' was
> not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
> ---
> arch/arm/mach-oxnas/platsmp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-oxnas/platsmp.c b/arch/arm/mach-oxnas/platsmp.c
> index ab35275..f0a50b9 100644
> --- a/arch/arm/mach-oxnas/platsmp.c
> +++ b/arch/arm/mach-oxnas/platsmp.c
> @@ -27,7 +27,8 @@ static void __iomem *gic_cpu_ctrl;
> #define GIC_CPU_CTRL 0x00
> #define GIC_CPU_CTRL_ENABLE 1
>
> -int __init ox820_boot_secondary(unsigned int cpu, struct task_struct *idle)
> +static int __init ox820_boot_secondary(unsigned int cpu,
> + struct task_struct *idle)
> {
> /*
> * Write the address of secondary startup into the
> --
> 2.7.4
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-12 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 1:46 [PATCH] ARM: oxnas: make ox820_boot_secondary static Ma Feng
2020-05-12 8:24 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®