* Re: [PATCH] fork: clear p->mm when copy_process() fails
2026-11-19 8:04 [PATCH] fork: clear p->mm when copy_process() fails David Hildenbrand (Arm)
@ 2026-11-19 8:29 ` Michal Hocko
2026-11-19 11:33 ` Lorenzo Stoakes (ARM)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Michal Hocko @ 2026-11-19 8:29 UTC (permalink / raw)
To: David Hildenbrand (Arm)
Cc: Andrew Morton, Lorenzo Stoakes, Liam R. Howlett, Vlastimil Babka,
Mike Rapoport, Suren Baghdasaryan, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Ben Segall, Mel Gorman, Valentin Schneider, K Prateek Nayak,
Kees Cook, Alexander Shishkin, Mathieu Poirier,
Alexei Starovoitov, Song Liu, Yonghong Song, Ingo Molnar,
linux-mm, linux-kernel, bpf, Chris Mason, Sashiko, stable
On Thu 19-11-26 09:04:58, David Hildenbrand wrote:
> From: Chris Mason <mason@kernel.org>
>
> When copy_process() fails after copy_mm(), the error path drops the mm
> reference but leaves p->mm set. Perf and BPF can still reach the
> task, and take a reference on the already freed mm through get_task_mm()
> or bpf_find_vma(), resulting in a use-after-free:
>
> copy_process() PERF_EVENT_IOC_SET_FILTER
> ============== =========================
> perf_event_init_task(p)
> copy_mm(p)
> a later step fails
> mmput(p->mm)
> /* frees the mm */
> perf_event_addr_filters_apply()
> get_task_mm(p)
> /* use-after-free */
>
> Similarly, a BPF program on the task_free LSM hook can call bpf_find_vma(p)
> before the task is freed.
>
> Fix it by clearing p->mm under task_lock() before dropping the reference,
> just like exit_mm() does.
>
> Further, if copy_process() fails before copy_mm(), p->mm is still the
> parent's mm pointer copied by dup_task_struct(), without having taken a
> reference. While nobody can access it concurrently, there is the
> chance that it might get accessed later when a BPF program is attached
> to free_task().
>
> With CONFIG_MEMCG the task is freed after an RCU grace period, so the
> parent might already be gone and p->mm in the child points at something
> that was already freed. So let's just clear p->mm before freeing the
> task. No lock is required as there cannot be concurrent access (and we
> might not even have the lock initialized yet).
>
> This has medium urgency.
>
> Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
> Fixes: 7c7e3d31e785 ("bpf: Introduce helper bpf_find_vma")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/sashiko-outbox-180866@kernel.org/
> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Mason <mason@kernel.org>
> [ david: simplify description and comments ]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> I can take this through my tree (rather soonish) unless someone else
> wants to pick this up.
> ---
> kernel/fork.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 5efceb8d58a78..77d6c8fc38c66 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2628,8 +2628,14 @@ __latent_entropy struct task_struct *copy_process(
> bad_fork_cleanup_mm:
> sched_cache_fork_cleanup(p);
> if (p->mm) {
> - mm_clear_owner(p->mm, p);
> - mmput(p->mm);
> + struct mm_struct *mm = p->mm;
> +
> + /* Perf events and BPF programs can still reach p. */
> + task_lock(p);
> + p->mm = NULL;
> + task_unlock(p);
> + mm_clear_owner(mm, p);
> + mmput(mm);
> }
> bad_fork_cleanup_signal:
> if (!(clone_flags & CLONE_THREAD))
> @@ -2663,6 +2669,11 @@ __latent_entropy struct task_struct *copy_process(
> exit_cred_namespaces(p);
> exit_creds(p);
> bad_fork_free:
> + /*
> + * If set, p->mm points at the parent's mm without a reference. Nobody
> + * can access it concurrently anymore, but prevent later access.
> + */
> + p->mm = NULL;
> WRITE_ONCE(p->__state, TASK_DEAD);
> exit_task_stack_account(p);
> put_task_stack(p);
>
> ---
> base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
> change-id: 20261119-mm_failed_fork-a46141b503d0
>
> Best regards,
> --
> David Hildenbrand (Arm) <david@kernel.org>
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fork: clear p->mm when copy_process() fails
2026-11-19 8:04 [PATCH] fork: clear p->mm when copy_process() fails David Hildenbrand (Arm)
2026-11-19 8:29 ` Michal Hocko
@ 2026-11-19 11:33 ` Lorenzo Stoakes (ARM)
2026-11-19 16:00 ` Bradley Morgan
2026-11-19 16:43 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-11-19 11:33 UTC (permalink / raw)
To: David Hildenbrand (Arm)
Cc: Andrew Morton, Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, Ingo Molnar, Peter Zijlstra,
Juri Lelli, Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Ben Segall, Mel Gorman, Valentin Schneider, K Prateek Nayak,
Kees Cook, Alexander Shishkin, Mathieu Poirier,
Alexei Starovoitov, Song Liu, Yonghong Song, Ingo Molnar,
linux-mm, linux-kernel, bpf, Chris Mason, Sashiko, stable
On Thu, Nov 19, 2026 at 09:04:58AM +0100, David Hildenbrand (Arm) wrote:
> From: Chris Mason <mason@kernel.org>
>
> When copy_process() fails after copy_mm(), the error path drops the mm
> reference but leaves p->mm set. Perf and BPF can still reach the
> task, and take a reference on the already freed mm through get_task_mm()
> or bpf_find_vma(), resulting in a use-after-free:
Good lord :)
>
> copy_process() PERF_EVENT_IOC_SET_FILTER
> ============== =========================
> perf_event_init_task(p)
> copy_mm(p)
> a later step fails
> mmput(p->mm)
> /* frees the mm */
> perf_event_addr_filters_apply()
> get_task_mm(p)
> /* use-after-free */
>
> Similarly, a BPF program on the task_free LSM hook can call bpf_find_vma(p)
> before the task is freed.
>
> Fix it by clearing p->mm under task_lock() before dropping the reference,
> just like exit_mm() does.
Sounds sensible.
>
> Further, if copy_process() fails before copy_mm(), p->mm is still the
> parent's mm pointer copied by dup_task_struct(), without having taken a
> reference. While nobody can access it concurrently, there is the
> chance that it might get accessed later when a BPF program is attached
> to free_task().
>
> With CONFIG_MEMCG the task is freed after an RCU grace period, so the
> parent might already be gone and p->mm in the child points at something
> that was already freed. So let's just clear p->mm before freeing the
> task. No lock is required as there cannot be concurrent access (and we
> might not even have the lock initialized yet).
>
> This has medium urgency.
It sounds... horrendous though :) but I guess possibly hard to hit?
>
> Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
> Fixes: 7c7e3d31e785 ("bpf: Introduce helper bpf_find_vma")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/sashiko-outbox-180866@kernel.org/
> Cc: stable@vger.kernel.org
> Signed-off-by: Chris Mason <mason@kernel.org>
> [ david: simplify description and comments ]
> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
LGTM so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> I can take this through my tree (rather soonish) unless someone else
> wants to pick this up.
> ---
> kernel/fork.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 5efceb8d58a78..77d6c8fc38c66 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2628,8 +2628,14 @@ __latent_entropy struct task_struct *copy_process(
> bad_fork_cleanup_mm:
> sched_cache_fork_cleanup(p);
> if (p->mm) {
> - mm_clear_owner(p->mm, p);
> - mmput(p->mm);
> + struct mm_struct *mm = p->mm;
> +
> + /* Perf events and BPF programs can still reach p. */
> + task_lock(p);
> + p->mm = NULL;
> + task_unlock(p);
> + mm_clear_owner(mm, p);
> + mmput(mm);
> }
> bad_fork_cleanup_signal:
> if (!(clone_flags & CLONE_THREAD))
> @@ -2663,6 +2669,11 @@ __latent_entropy struct task_struct *copy_process(
> exit_cred_namespaces(p);
> exit_creds(p);
> bad_fork_free:
> + /*
> + * If set, p->mm points at the parent's mm without a reference. Nobody
> + * can access it concurrently anymore, but prevent later access.
> + */
> + p->mm = NULL;
> WRITE_ONCE(p->__state, TASK_DEAD);
> exit_task_stack_account(p);
> put_task_stack(p);
>
> ---
> base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
> change-id: 20261119-mm_failed_fork-a46141b503d0
>
> Best regards,
> --
> David Hildenbrand (Arm) <david@kernel.org>
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fork: clear p->mm when copy_process() fails
2026-11-19 8:04 [PATCH] fork: clear p->mm when copy_process() fails David Hildenbrand (Arm)
2026-11-19 8:29 ` Michal Hocko
2026-11-19 11:33 ` Lorenzo Stoakes (ARM)
@ 2026-11-19 16:00 ` Bradley Morgan
2026-11-19 16:43 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: Bradley Morgan @ 2026-11-19 16:00 UTC (permalink / raw)
To: david
Cc: akpm, alexander.shishkin, ast, bpf, bsegall, dietmar.eggemann,
juri.lelli, kees, kprateek.nayak, liam, linux-kernel, linux-mm,
ljs, mason, mathieu.poirier, mgorman, mhocko, mingo, mingo,
peterz, rostedt, rppt, sashiko-bot, songliubraving, stable,
surenb, vbabka, vincent.guittot, vschneid, yhs
On 19 November 2026 08:04:58 GMT, "David Hildenbrand (Arm)"
<david@kernel.org> wrote:
>From: Chris Mason <mason@kernel.org>
>
>When copy_process() fails after copy_mm(), the error path drops the mm
>reference but leaves p->mm set. Perf and BPF can still reach the
>task, and take a reference on the already freed mm through get_task_mm()
>or bpf_find_vma(), resulting in a use-after-free:
>
> copy_process() PERF_EVENT_IOC_SET_FILTER
> ============== =========================
> perf_event_init_task(p)
> copy_mm(p)
> a later step fails
> mmput(p->mm)
> /* frees the mm */
> perf_event_addr_filters_apply()
> get_task_mm(p)
> /* use-after-free */
>
>Similarly, a BPF program on the task_free LSM hook can call
>bpf_find_vma(p)
>before the task is freed.
>
>Fix it by clearing p->mm under task_lock() before dropping the reference,
>just like exit_mm() does.
>
>Further, if copy_process() fails before copy_mm(), p->mm is still the
>parent's mm pointer copied by dup_task_struct(), without having taken a
>reference. While nobody can access it concurrently, there is the
>chance that it might get accessed later when a BPF program is attached
>to free_task().
>
>With CONFIG_MEMCG the task is freed after an RCU grace period, so the
>parent might already be gone and p->mm in the child points at something
>that was already freed. So let's just clear p->mm before freeing the
>task. No lock is required as there cannot be concurrent access (and we
>might not even have the lock initialized yet).
>
>This has medium urgency.
>
>Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
>Fixes: 7c7e3d31e785 ("bpf: Introduce helper bpf_find_vma")
>Reported-by: Sashiko <sashiko-bot@kernel.org>
>Closes: https://lore.kernel.org/sashiko-outbox-180866@kernel.org/
>Cc: stable@vger.kernel.org
>Signed-off-by: Chris Mason <mason@kernel.org>
>[ david: simplify description and comments ]
Reviewed-by: Bradley Morgan <bradley.morgan@linux.dev>
>Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
>---
>I can take this through my tree (rather soonish) unless someone else
>wants to pick this up.
>---
> kernel/fork.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
>diff --git a/kernel/fork.c b/kernel/fork.c
>index 5efceb8d58a78..77d6c8fc38c66 100644
>--- a/kernel/fork.c
>+++ b/kernel/fork.c
>@@ -2628,8 +2628,14 @@ __latent_entropy struct task_struct *copy_process(
> bad_fork_cleanup_mm:
> sched_cache_fork_cleanup(p);
> if (p->mm) {
>- mm_clear_owner(p->mm, p);
>- mmput(p->mm);
>+ struct mm_struct *mm = p->mm;
>+
>+ /* Perf events and BPF programs can still reach p. */
>+ task_lock(p);
>+ p->mm = NULL;
>+ task_unlock(p);
>+ mm_clear_owner(mm, p);
>+ mmput(mm);
> }
> bad_fork_cleanup_signal:
> if (!(clone_flags & CLONE_THREAD))
>@@ -2663,6 +2669,11 @@ __latent_entropy struct task_struct *copy_process(
> exit_cred_namespaces(p);
> exit_creds(p);
> bad_fork_free:
>+ /*
>+ * If set, p->mm points at the parent's mm without a reference. Nobody
>+ * can access it concurrently anymore, but prevent later access.
>+ */
>+ p->mm = NULL;
> WRITE_ONCE(p->__state, TASK_DEAD);
> exit_task_stack_account(p);
> put_task_stack(p);
>
>---
>base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
>change-id: 20261119-mm_failed_fork-a46141b503d0
>
>Best regards,
>--
>David Hildenbrand (Arm) <david@kernel.org>
>
>
>
--- Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] fork: clear p->mm when copy_process() fails
2026-11-19 8:04 [PATCH] fork: clear p->mm when copy_process() fails David Hildenbrand (Arm)
` (2 preceding siblings ...)
2026-11-19 16:00 ` Bradley Morgan
@ 2026-11-19 16:43 ` David Hildenbrand
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2026-11-19 16:43 UTC (permalink / raw)
To: Andrew Morton, Lorenzo Stoakes, Liam R. Howlett, Vlastimil Babka,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Ingo Molnar,
Peter Zijlstra, Juri Lelli, Vincent Guittot, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman, Valentin Schneider,
K Prateek Nayak, Kees Cook, Alexander Shishkin, Mathieu Poirier,
Alexei Starovoitov, Song Liu, Yonghong Song, Ingo Molnar,
David Hildenbrand (Arm)
Cc: linux-mm, linux-kernel, bpf, Chris Mason, Sashiko, stable
On Thu, 19 Nov 2026 09:04:58 +0100, David Hildenbrand (Arm) wrote:
> When copy_process() fails after copy_mm(), the error path drops the mm
> reference but leaves p->mm set. Perf and BPF can still reach the
> task, and take a reference on the already freed mm through get_task_mm()
> or bpf_find_vma(), resulting in a use-after-free:
>
> copy_process() PERF_EVENT_IOC_SET_FILTER
> ============== =========================
> perf_event_init_task(p)
> copy_mm(p)
> a later step fails
> mmput(p->mm)
> /* frees the mm */
> perf_event_addr_filters_apply()
> get_task_mm(p)
> /* use-after-free */
>
> [...]
Applied, thanks!
tree: mm/core.git
branch: for-next-fixes
Applied patches will appear soon in mm-next, followed by linux-next.
Please report any outstanding bugs that were missed during review, so we
can either drop the patch series or decide how to fix it up.
It is encouraged to provide Acked-bys, Reviewed-bys, and Tested-bys even
though the patches have already been applied. If possible, patch trailers
will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. Further, this is not a guarantee that the
patches will go upstream. If in doubt, please check the listed branch.
[1/1] fork: clear p->mm when copy_process() fails
https://git.kernel.org/mm/core/c/c9b8c9bd
--
Cheers,
David
^ permalink raw reply [flat|nested] 5+ messages in thread