From: Kees Cook <kees@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Terry Tritton <terry.tritton@linaro.org>
Cc: hch@lst.de, "ttritton@google.com" <ttritton@google.com>,
edliaw@google.com, keescook@chromium.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>
Subject: Re: Change in splice() behaviour after 5.10?
Date: Mon, 03 Jun 2024 22:43:31 -0700 [thread overview]
Message-ID: <7F3B484F-9555-486A-B19A-5A8EB6442988@kernel.org> (raw)
In-Reply-To: <20240604045030.GA29276@lst.de>
On June 3, 2024 9:50:30 PM PDT, Christoph Hellwig <hch@lst.de> wrote:
>On Mon, Jun 03, 2024 at 10:59:15AM +0100, Terry Tritton wrote:
>> Hi,
>> We've found a change in behaviour while testing the splice07 LTP test.
>> In versions before 5.10 the test will hang on certain combinations but after
>> 5.10 the splice call will return.
>> I bisected the change to the following commit:
>> 36e2c7421f02a22f71c9283e55fdb672a9eb58e7
>> fs: don't allow splice read/write without explicit ops
>>
>> There has been some discussion on the LTP github page already:
>> https://github.com/linux-test-project/ltp/issues/1156
>
>In that case the return probably is an error because epoll doesn't
>support read_iter/write_iter and thus completely expected.
>
>If the underlying bug hasn't been fix in the mean time that probably
>means it will be back if Jens' conversion of all misc file operations
>to the iter based ones every gets merged.
>
>If you are interested more in this please discuss it on the relevant
>mailing lists instead of in private mail.
Eh? LKML is in CC...
I've added fsdevel and Jens now too, though.
-Kees
--
Kees Cook
prev parent reply other threads:[~2024-06-04 5:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 9:59 Terry Tritton
2024-06-04 4:50 ` Christoph Hellwig
2024-06-04 5:43 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F3B484F-9555-486A-B19A-5A8EB6442988@kernel.org \
--to=kees@kernel.org \
--cc=axboe@kernel.dk \
--cc=edliaw@google.com \
--cc=hch@lst.de \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=terry.tritton@linaro.org \
--cc=ttritton@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®