From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
To: Jan Kiszka <jan.kiszka@siemens.com>,
Matt Schulte <matts@commtech-fastcom.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>
Subject: Re: gpio-exar: Why filtering out Commtech devices?
Date: Sun, 21 May 2017 21:08:41 +0100 [thread overview]
Message-ID: <7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk> (raw)
In-Reply-To: <18f4b5cb-cba0-aab4-7958-84a5b8d28935@siemens.com>
Hi Jan,
On 21/05/17 12:46, Jan Kiszka wrote:
> Hi Sudip,
>
> why do we carry
>
> if (pcidev->vendor != PCI_VENDOR_ID_EXAR)
> return -ENODEV;
>
> in gpio_exar_probe? This effectively prevents that
>
> EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x),
> EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x),
> EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x),
>
> gain GPIO support. Do those devices lack access to the pins? Or can we
> drop the filter. I don't have access to those devices, just wondering
> because the code is not explaining the reason.
Same here. I do not have these devices and have no idea if they support
the gpio pins or not.
Adding Matt Schulte in the Cc list, maybe he can comment.
--
Regards
Sudip
next prev parent reply other threads:[~2017-05-21 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 11:46 Jan Kiszka
2017-05-21 20:08 ` Sudip Mukherjee [this message]
2017-05-22 5:48 ` Jan Kiszka
2017-05-22 5:51 ` Jan Kiszka
[not found] ` <CAPpjZG9MGDzS0Bu2c6M-Pob5JkzeAptDu8QNnDJETinCenee0w@mail.gmail.com>
2017-05-22 16:24 ` Jan Kiszka
2017-05-22 18:18 ` Jan Kiszka
[not found] ` <CAPpjZG_HPFqKzf+7rBxM27TJcZJ4+vfUYSPChifM-JTN7ekTOA@mail.gmail.com>
2017-05-23 15:05 ` Jan Kiszka
[not found] ` <CAPpjZG953JHZWt8UzgEmYurSMh9o1v5HvxmO+4FD41M92GA-Ww@mail.gmail.com>
2017-05-23 21:16 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a25751e-931f-b713-dcdd-7a7483aae115@codethink.co.uk \
--to=sudip.mukherjee@codethink.co.uk \
--cc=jan.kiszka@siemens.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matts@commtech-fastcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®