From: Daniel Golle <daniel@makrotopia.org>
To: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Russell King" <linux@armlinux.org.uk>,
"Arınç Ünal" <arinc.unal@arinc9.com>
Cc: Sam Shih <Sam.Shih@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>
Subject: [PATCH net-next v2 09/14] net: dsa: mt7530: introduce mt7530_remove_common helper function
Date: Mon, 3 Apr 2023 02:18:50 +0100 [thread overview]
Message-ID: <7a2829bb037d27a57e588fe0157174ee47d37c3b.1680483896.git.daniel@makrotopia.org> (raw)
In-Reply-To: <cover.1680483895.git.daniel@makrotopia.org>
Move commonly used parts from mt7530_remove into new
mt7530_remove_common helper function which will be used by both,
mt7530_remove and the to-be-introduced mt7988_remove.
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mt7530.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index a60ed8706ce35..9404675c47222 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -3259,6 +3259,17 @@ mt7530_probe(struct mdio_device *mdiodev)
return dsa_register_switch(priv->ds);
}
+static void
+mt7530_remove_common(struct mt7530_priv *priv)
+{
+ if (priv->irq)
+ mt7530_free_irq(priv);
+
+ dsa_unregister_switch(priv->ds);
+
+ mutex_destroy(&priv->reg_mutex);
+}
+
static void
mt7530_remove(struct mdio_device *mdiodev)
{
@@ -3278,15 +3289,10 @@ mt7530_remove(struct mdio_device *mdiodev)
dev_err(priv->dev, "Failed to disable io pwr: %d\n",
ret);
- if (priv->irq)
- mt7530_free_irq(priv);
-
- dsa_unregister_switch(priv->ds);
+ mt7530_remove_common(priv);
for (i = 0; i < 2; ++i)
mtk_pcs_lynxi_destroy(priv->ports[5 + i].sgmii_pcs);
-
- mutex_destroy(&priv->reg_mutex);
}
static void mt7530_shutdown(struct mdio_device *mdiodev)
--
2.40.0
next prev parent reply other threads:[~2023-04-03 1:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 1:16 [PATCH net-next v2 00/14] net: dsa: add support for MT7988 Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 01/14] net: dsa: mt7530: make some noise if register read fails Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 02/14] net: dsa: mt7530: refactor SGMII PCS creation Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 03/14] net: dsa: mt7530: use unlocked regmap accessors Daniel Golle
2023-04-03 1:17 ` [PATCH net-next v2 04/14] net: dsa: mt7530: use regmap to access switch register space Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 05/14] net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 06/14] net: dsa: mt7530: introduce mutex helpers Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 07/14] net: dsa: mt7530: move p5_intf_modes() function to mt7530.c Daniel Golle
2023-04-03 1:18 ` [PATCH net-next v2 08/14] net: dsa: mt7530: introduce mt7530_probe_common helper function Daniel Golle
2023-04-03 1:18 ` Daniel Golle [this message]
2023-04-03 1:19 ` [PATCH net-next v2 10/14] net: dsa: mt7530: split-off common parts from mt7531_setup Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 11/14] net: dsa: mt7530: introduce separate MDIO driver Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 12/14] net: dsa: mt7530: skip locking if MDIO bus isn't present Daniel Golle
2023-04-03 1:19 ` [PATCH net-next v2 13/14] net: dsa: mt7530: introduce driver for MT7988 built-in switch Daniel Golle
2023-04-25 15:51 ` Philipp Zabel
2023-04-25 16:11 ` Daniel Golle
2023-04-26 7:44 ` Philipp Zabel
2023-04-03 1:19 ` [PATCH net-next v2 14/14] dt-bindings: net: dsa: mediatek,mt7530: add mediatek,mt7988-switch Daniel Golle
2023-04-03 9:20 ` [PATCH net-next v2 00/14] net: dsa: add support for MT7988 patchwork-bot+netdevbpf
2023-04-03 17:08 ` Arınç ÜNAL
2023-04-03 17:42 ` Daniel Golle
2023-04-03 17:50 ` Arınç ÜNAL
2023-04-03 18:13 ` Daniel Golle
2023-04-03 18:26 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a2829bb037d27a57e588fe0157174ee47d37c3b.1680483896.git.daniel@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=Landen.Chao@mediatek.com \
--cc=Sam.Shih@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®