[PATCH 0/2] ACPI: processor: idle: acpi_processor_get_cstate_info() cleanup

[PATCH 0/2] ACPI: processor: idle: acpi_processor_get_cstate_info() cleanup

[Zhang Rui]

This patch series does further cleanups for
acpi_processor_get_cstate_info() on top of
https://lore.kernel.org/all/20250328143040.9348-2-ggherdovich@suse.cz/

thanks,
rui

----------------------------------------------------------------
Zhang Rui (2):
      ACPI: processor: idle: Set pr->flags.power unconditionally
      ACPI: processor: idle: Remove redundant pr->power.count assignment

 drivers/acpi/processor_idle.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

[PATCH 1/2] ACPI: processor: idle: Set pr->flags.power unconditionally

[Zhang Rui]

acpi_processor_get_power_info_default() ensures that the processor's
ACPI_STATE_C1 state is always valid. Consequently, the pr->flags.power
should be set unconditionally after this.

Remove conditional checks and directly set pr->flags.power.

No functional change.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/processor_idle.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 2a076c7a825a..7264444d56b8 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -481,11 +481,11 @@ static int acpi_processor_get_cstate_info(struct acpi_processor *pr)
 	acpi_processor_get_power_info_default(pr);
 
 	pr->power.count = acpi_processor_power_verify(pr);
+	pr->flags.power = 1;
 
 	for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
 		if (pr->power.states[i].valid) {
 			pr->power.count = i;
-			pr->flags.power = 1;
 		}
 	}
 
-- 
2.43.0

[PATCH 2/2] ACPI: processor: idle: Remove redundant pr->power.count assignment

[Zhang Rui]

pr->power.count stands for the number of valid processor cstates. And it
is correctly set with the return value of acpi_processor_power_verify(),
in acpi_processor_get_cstate_info().

Remove the redundant logic that unnecessarily overrides pr->power.count
value.

No functional change intended.

Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/processor_idle.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 7264444d56b8..623c415790b0 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -483,12 +483,6 @@ static int acpi_processor_get_cstate_info(struct acpi_processor *pr)
 	pr->power.count = acpi_processor_power_verify(pr);
 	pr->flags.power = 1;
 
-	for (i = 1; i < ACPI_PROCESSOR_MAX_POWER; i++) {
-		if (pr->power.states[i].valid) {
-			pr->power.count = i;
-		}
-	}
-
 	return 0;
 }
 
-- 
2.43.0

Re: [PATCH 0/2] ACPI: processor: idle: acpi_processor_get_cstate_info() cleanup

[Giovanni Gherdovich]

On Wed Apr 9, 2025 02:50, Zhang Rui wrote:
> This patch series does further cleanups for
> acpi_processor_get_cstate_info() on top of
> https://lore.kernel.org/all/20250328143040.9348-2-ggherdovich@suse.cz/
> 
> thanks,
> rui
> 
> ----------------------------------------------------------------
> Zhang Rui (2):
>        ACPI: processor: idle: Set pr->flags.power unconditionally
>        ACPI: processor: idle: Remove redundant pr->power.count assignment
> 
>   drivers/acpi/processor_idle.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)

Thanks a lot Rui for this cleanup.

To the series:

Acked-by: Giovanni Gherdovich <ggherdovich@suse.cz>