mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	alexandre.belloni@bootlin.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	jarkko.nikula@linux.intel.com, linux-i3c@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Frank.Li@nxp.com,
	wsa+renesas@sang-engineering.com, alok.a.tiwari@oracle.com
Cc: andersson@kernel.org, konradybcio@kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller
Date: Wed, 23 Sep 2026 15:05:42 +0530	[thread overview]
Message-ID: <7a452005-ad63-4687-8cd2-6dbd054cb4f3@oss.qualcomm.com> (raw)
In-Reply-To: <a3eaf9e3-5c18-42ba-a645-2efdfe161fd5@oss.qualcomm.com>



On 9/22/2026 3:40 PM, Konrad Dybcio wrote:
> On 9/21/26 10:28 PM, Mukesh Savaliya wrote:
>> Hi Konrad, Apologies for the delayed response. I was waiting to verify the changes and ensure all the suggested updates were properly incorporated. The effort was further delayed due to some slave-side setup issues.
>>
>> I have now addressed and validated all the suggested changes except one, which I have responded to separately below.
>>
>> On 7/18/2025 2:21 AM, Konrad Dybcio wrote:
>>> On 7/1/25 9:18 AM, Mukesh Kumar Savaliya wrote:
>>>> Add device tree bindings for the Qualcomm I3C controller. This includes
>>>> the necessary documentation and properties required to describe the
>>>> hardware in the device tree.
>>>>
>>>> Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
>>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>>> ---
>>>
>>> [...]
>>>
>>>> +properties:
>>>> +  compatible:
>>>> +    const: qcom,geni-i3c
>>>> +
>>>> +  reg:
>>>> +    maxItems: 1
>>>
>>> In another patchset, you expanded 'reg', can you coalesce that change
>>> into here, so that we don't have to worry about backwards compat?
>>>
>> Do you mean as below ?
>> reg:
>>    minItems: 1
>>    maxItems: 2
> 
> No, I meant that since you know in advance you'll need the bindings
> to be altered, simply squash the two bindings patches together and
> submit as one
> 
> Konrad
> 

Sure, will publish full dt-binding describing I3C hardware including IBI 
related information and accordingly update the commit log.

>>
>> I did it earlier to add support of IBI feature, but i plan to do it later. Right now, i only want to add plain i3c controller support without IBI hence.
>>
>> I shall add expanded reg while adding i3c support. For now, its not required. Please let me know if this is fine for now.
>>
>>> Konrad
>>


  reply	other threads:[~2026-09-23  9:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01  7:18 [PATCH v6 0/3] Add Qualcomm i3c controller driver support Mukesh Kumar Savaliya
2025-07-01  7:18 ` [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller Mukesh Kumar Savaliya
2025-07-01  8:30   ` Rob Herring (Arm)
2025-07-01  8:33   ` Krzysztof Kozlowski
     [not found]     ` <b7d120c8-1215-4923-8810-83cc0d7cdc36@quicinc.com>
2026-09-21 20:31       ` Mukesh Savaliya
2025-07-01  8:53   ` ALOK TIWARI
2025-07-01  8:58   ` Krzysztof Kozlowski
2025-07-17 20:51   ` Konrad Dybcio
2026-09-21 20:28     ` Mukesh Savaliya
2026-09-22 10:10       ` Konrad Dybcio
2026-09-23  9:35         ` Mukesh Savaliya [this message]
2025-07-01  7:18 ` [PATCH v6 2/3] i3c: master: Add Qualcomm I3C controller driver Mukesh Kumar Savaliya
2025-07-01  8:43   ` Krzysztof Kozlowski
2026-09-21 20:33     ` Mukesh Savaliya
2025-07-01  8:48   ` ALOK TIWARI
2026-09-21 20:32     ` Mukesh Savaliya
2025-07-01 16:40   ` Frank Li
     [not found]     ` <c1060b7d-a621-4805-8fac-11621b6f564f@quicinc.com>
2026-09-21 20:34       ` Mukesh Savaliya
2025-07-01 20:56   ` Bjorn Andersson
     [not found]     ` <9e3da313-ab1f-435d-8e3c-1a0c946a7790@quicinc.com>
2026-09-21 20:35       ` Mukesh Savaliya
2025-07-01  7:18 ` [PATCH v6 3/3] MAINTAINERS: Add maintainer for Qualcomm's " Mukesh Kumar Savaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a452005-ad63-4687-8cd2-6dbd054cb4f3@oss.qualcomm.com \
    --to=mukesh.savaliya@oss.qualcomm.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®