Re: [PATCH v6 1/3] dt-bindings: i3c: Add support for Qualcomm I3C controller

[Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>]

Hi Krzysztof , Apologies for the delayed response. I was waiting to 
verify the changes and ensure all the suggested updates were properly 
incorporated. The effort was further delayed due to some slave-side 
setup issues.

Since, I migrated from my @quicinc.com email address to 
@oss.qualcomm.com and could not locate the original email thread. The 
replies below are from a draft I had saved earlier.

I have now addressed and validated all the suggested changes except one, 
which I have responded to separately below.  I shall upload V7 cleanly soon.
> On 7/1/2025 2:03 PM, Krzysztof Kozlowski wrote:
>> On 01/07/2025 09:18, Mukesh Kumar Savaliya wrote:
>>> Add device tree bindings for the Qualcomm I3C controller. This includes
>>> the necessary documentation and properties required to describe the
>>> hardware in the device tree.
>>>
>>> Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>>   .../bindings/i3c/qcom,geni-i3c.yaml           | 59 +++++++++++++++++++
>>>   1 file changed, 59 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/i3c/qcom,geni- 
>>> i3c.yaml
>>>
>>
>> It's v6, you really should have started testing your changes by that
>> time. :/
>>

yes, clock-names - Got added by mistake while uploading, will remove it
in next patch. Will run both dtbs_check and dt_binding_check before next 
  patch.


>> Nothing in the changelog explains the change made here, so you just
>> sneaked something which did not work.
>>

I didn't made any change into this binding file. I would have added in
change log V5 to V6 if there was any change in this yaml file.

If you find anything else getting added, except "clock-names", please
let me know.

> 
>> Best regards,
>> Krzysztof
>>
>