* [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon
@ 2024-09-19 3:53 Chen Ni
2024-09-19 4:45 ` Baolu Lu
0 siblings, 1 reply; 3+ messages in thread
From: Chen Ni @ 2024-09-19 3:53 UTC (permalink / raw)
To: will, robin.murphy, joro, jgg, nicolinc, mshavit, smostafa, baolu.lu
Cc: linux-arm-kernel, iommu, linux-kernel, Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 737c5b882355..4815c5198642 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -1420,7 +1420,7 @@ static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master)
cd_table->s1fmt = STRTAB_STE_0_S1FMT_LINEAR;
cd_table->linear.num_ents = max_contexts;
- l1size = max_contexts * sizeof(struct arm_smmu_cd),
+ l1size = max_contexts * sizeof(struct arm_smmu_cd);
cd_table->linear.table = dma_alloc_coherent(smmu->dev, l1size,
&cd_table->cdtab_dma,
GFP_KERNEL);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon
2024-09-19 3:53 [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
@ 2024-09-19 4:45 ` Baolu Lu
2024-09-20 12:50 ` Jason Gunthorpe
0 siblings, 1 reply; 3+ messages in thread
From: Baolu Lu @ 2024-09-19 4:45 UTC (permalink / raw)
To: Chen Ni, will, robin.murphy, joro, jgg, nicolinc, mshavit, smostafa
Cc: baolu.lu, linux-arm-kernel, iommu, linux-kernel
On 9/19/24 11:53 AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni<nichen@iscas.ac.cn>
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
A typo in commit e3b1be2e73dbe ("iommu/arm-smmu-v3: Reorganize struct
arm_smmu_ctx_desc_cfg").
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Thanks,
baolu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon
2024-09-19 4:45 ` Baolu Lu
@ 2024-09-20 12:50 ` Jason Gunthorpe
0 siblings, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2024-09-20 12:50 UTC (permalink / raw)
To: Baolu Lu
Cc: Chen Ni, will, robin.murphy, joro, nicolinc, mshavit, smostafa,
linux-arm-kernel, iommu, linux-kernel
On Thu, Sep 19, 2024 at 12:45:18PM +0800, Baolu Lu wrote:
> On 9/19/24 11:53 AM, Chen Ni wrote:
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni<nichen@iscas.ac.cn>
> > ---
> > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> A typo in commit e3b1be2e73dbe ("iommu/arm-smmu-v3: Reorganize struct
> arm_smmu_ctx_desc_cfg").
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Yes should have a fixes line, plese include and resend it..
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-20 12:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-19 3:53 [PATCH] iommu/arm-smmu-v3: Convert comma to semicolon Chen Ni
2024-09-19 4:45 ` Baolu Lu
2024-09-20 12:50 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®