mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kurbanov <mmkurbanov@salutedevices.com>
To: Ezra Buehler <ezra@easyb.ch>, <linux-mtd@lists.infradead.org>
Cc: Chuanhong Guo <gch981213@gmail.com>,
	Dmitry Rokosov <ddrokosov@sberdevices.ru>,
	Martin Kurbanov <mmkurbanov@sberdevices.ru>,
	Md Sadre Alam <quic_mdalam@quicinc.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Sridharan S N <quic_sridsn@quicinc.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mtd: spinand: Add support for 5-byte IDs
Date: Fri, 26 Jan 2024 21:46:33 +0300	[thread overview]
Message-ID: <7a5c147b-e531-4aa3-8439-1b80d8ed7747@salutedevices.com> (raw)
In-Reply-To: <20240125200108.24374-2-ezra@easyb.ch>



On 25.01.2024 23:01, Ezra Buehler wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
> 
> E.g. ESMT chips will return an identification code with a length of 5
> bytes. In order to prevent ambiguity, flash chips would actually need to
> return IDs that are up to 17 or more bytes long due to JEDEC's
> continuation scheme. I understand that if a manufacturer ID is located
> in bank N of JEDEC's database (there are currently 16 banks), N - 1
> continuation codes (7Fh) need to be added to the identification code
> (comprising of manufacturer ID and device ID). However, most flash chip
> manufacturers don't seem to implement this (correctly).
> 
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>

Tested for F50L1G41LB

Reviewed-by: Martin Kurbanov <mmkurbanov@salutedevices.com>
Tested-by: Martin Kurbanov <mmkurbanov@salutedevices.com>

> ---
>  include/linux/mtd/spinand.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h
> index badb4c1ac079..5c19ead60499 100644
> --- a/include/linux/mtd/spinand.h
> +++ b/include/linux/mtd/spinand.h
> @@ -169,7 +169,7 @@
>  struct spinand_op;
>  struct spinand_device;
>  
> -#define SPINAND_MAX_ID_LEN	4
> +#define SPINAND_MAX_ID_LEN	5
>  /*
>   * For erase, write and read operation, we got the following timings :
>   * tBERS (erase) 1ms to 4ms

-- 
Best Regards,
Martin Kurbanov

  reply	other threads:[~2024-01-26 18:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 20:01 [PATCH 0/2] mtd: spinand: Resolve GigaDevice/ESMT ID clash Ezra Buehler
2024-01-25 20:01 ` [PATCH 1/2] mtd: spinand: Add support for 5-byte IDs Ezra Buehler
2024-01-26 18:46   ` Martin Kurbanov [this message]
2024-02-05 14:28   ` Miquel Raynal
2024-01-25 20:01 ` [PATCH 2/2] mtd: spinand: esmt: Extend IDs to 5 bytes Ezra Buehler
2024-01-26 18:48   ` Martin Kurbanov
2024-01-27  8:26     ` Ezra Buehler
2024-02-05 14:28   ` Miquel Raynal
2024-01-26 11:09 ` [PATCH 0/2] mtd: spinand: Resolve GigaDevice/ESMT ID clash Dmitry Rokosov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a5c147b-e531-4aa3-8439-1b80d8ed7747@salutedevices.com \
    --to=mmkurbanov@salutedevices.com \
    --cc=ddrokosov@sberdevices.ru \
    --cc=ezra@easyb.ch \
    --cc=gch981213@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mmkurbanov@sberdevices.ru \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_sridsn@quicinc.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®