From: Martin Kurbanov <mmkurbanov@salutedevices.com>
To: Ezra Buehler <ezra@easyb.ch>, <linux-mtd@lists.infradead.org>
Cc: Chuanhong Guo <gch981213@gmail.com>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>,
Martin Kurbanov <mmkurbanov@sberdevices.ru>,
Md Sadre Alam <quic_mdalam@quicinc.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Sridharan S N <quic_sridsn@quicinc.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mtd: spinand: esmt: Extend IDs to 5 bytes
Date: Fri, 26 Jan 2024 21:48:23 +0300 [thread overview]
Message-ID: <adf1fa3b-33eb-4def-97e3-55a7231430d4@salutedevices.com> (raw)
In-Reply-To: <20240125200108.24374-3-ezra@easyb.ch>
On 25.01.2024 23:01, Ezra Buehler wrote:
> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>
> According to the datasheets, the ESMT chips in question will return a 5
> byte long identification code where the last 3 bytes are the JEDEC
> continuation codes (7Fh). Although, I would have expected 4 continuation
> codes as Powerchip Semiconductor (C8h, corresponding to the parameter
> page data) is located in bank 5 of the JEDEC database.
>
> By matching the full 5 bytes we can avoid clashes with GigaDevice NAND
> flashes.
>
> This fix allows the MT7688-based GARDENA smart Gateway to boot again.
>
> Fixes: aa08bf187f32 ("mtd: spinand: esmt: add support for F50D2G41KA")
> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
Tested for F50L1G41LB
Reviewed-by: Martin Kurbanov <mmkurbanov@salutedevices.com>
Tested-by: Martin Kurbanov <mmkurbanov@salutedevices.com>
> ---
> drivers/mtd/nand/spi/esmt.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/esmt.c b/drivers/mtd/nand/spi/esmt.c
> index 31c439a557b1..4597a82de23a 100644
> --- a/drivers/mtd/nand/spi/esmt.c
> +++ b/drivers/mtd/nand/spi/esmt.c
> @@ -104,7 +104,8 @@ static const struct mtd_ooblayout_ops f50l1g41lb_ooblayout = {
>
> static const struct spinand_info esmt_c8_spinand_table[] = {
> SPINAND_INFO("F50L1G41LB",
> - SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x01),
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x01, 0x7f,
> + 0x7f, 0x7f),
> NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
> NAND_ECCREQ(1, 512),
> SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> @@ -113,7 +114,8 @@ static const struct spinand_info esmt_c8_spinand_table[] = {
> 0,
> SPINAND_ECCINFO(&f50l1g41lb_ooblayout, NULL)),
> SPINAND_INFO("F50D1G41LB",
> - SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x11),
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x11, 0x7f,
> + 0x7f, 0x7f),
> NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
> NAND_ECCREQ(1, 512),
> SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> @@ -122,7 +124,8 @@ static const struct spinand_info esmt_c8_spinand_table[] = {
> 0,
> SPINAND_ECCINFO(&f50l1g41lb_ooblayout, NULL)),
> SPINAND_INFO("F50D2G41KA",
> - SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x51),
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_ADDR, 0x51, 0x7f,
> + 0x7f, 0x7f),
> NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1),
> NAND_ECCREQ(8, 512),
> SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
--
Best Regards,
Martin Kurbanov
next prev parent reply other threads:[~2024-01-26 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 20:01 [PATCH 0/2] mtd: spinand: Resolve GigaDevice/ESMT ID clash Ezra Buehler
2024-01-25 20:01 ` [PATCH 1/2] mtd: spinand: Add support for 5-byte IDs Ezra Buehler
2024-01-26 18:46 ` Martin Kurbanov
2024-02-05 14:28 ` Miquel Raynal
2024-01-25 20:01 ` [PATCH 2/2] mtd: spinand: esmt: Extend IDs to 5 bytes Ezra Buehler
2024-01-26 18:48 ` Martin Kurbanov [this message]
2024-01-27 8:26 ` Ezra Buehler
2024-02-05 14:28 ` Miquel Raynal
2024-01-26 11:09 ` [PATCH 0/2] mtd: spinand: Resolve GigaDevice/ESMT ID clash Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf1fa3b-33eb-4def-97e3-55a7231430d4@salutedevices.com \
--to=mmkurbanov@salutedevices.com \
--cc=ddrokosov@sberdevices.ru \
--cc=ezra@easyb.ch \
--cc=gch981213@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mmkurbanov@sberdevices.ru \
--cc=quic_mdalam@quicinc.com \
--cc=quic_sridsn@quicinc.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®