From: tanhuazhong <tanhuazhong@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
<yisen.zhuang@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation
Date: Wed, 11 Nov 2020 10:31:55 +0800 [thread overview]
Message-ID: <7a7805e0-7d13-2b34-f15c-1fc7bda151ed@huawei.com> (raw)
In-Reply-To: <20201110172055.27ab308f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 2020/11/11 9:20, Jakub Kicinski wrote:
> On Mon, 9 Nov 2020 11:22:33 +0800 Huazhong Tan wrote:
>> Add dynamic interrupt moderation support for the HNS3 driver.
>>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>
> I'm slightly confused here. What does the adaptive moderation do in
> your driver/device if you still need DIM on top of it?
>
The driver's adaptive moderation and DIM are mutually-exclusive options,
and DIM is used by default. Since it is hard to verify all cases that
DIM can get a better result, so keep the adaptive moderation as an
option now, which can be swicthed by the ethtool priv-flag. If DIM is ok
for a long time, then we will send a separate patch to remove the
adaptive moderation from the driver.
Thanks.
>
next prev parent reply other threads:[~2020-11-11 2:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 3:22 [PATCH V2 net-next 00/11] net: hns3: updates for -next Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 01/11] net: hns3: add support for configuring interrupt quantity limiting Huazhong Tan
2020-11-11 1:13 ` Jakub Kicinski
2020-11-11 1:15 ` tanhuazhong
2020-11-09 3:22 ` [PATCH V2 net-next 02/11] net: hns3: add support for querying maximum value of GL Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 03/11] net: hns3: add support for 1us unit GL configuration Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 04/11] net: hns3: rename gl_adapt_enable in struct hns3_enet_coalesce Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 05/11] net: hns3: add support for dynamic interrupt moderation Huazhong Tan
2020-11-11 1:20 ` Jakub Kicinski
2020-11-11 2:31 ` tanhuazhong [this message]
2020-11-09 3:22 ` [PATCH V2 net-next 06/11] net: hns3: add ethtool priv-flag for DIM Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 07/11] net: hns3: add hns3_state_init() to do state initialization Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 08/11] net: hns3: add a check for ethtool priv-flag interface Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 09/11] net: hns3: add support for EQ/CQ mode configuration Huazhong Tan
2020-11-11 1:25 ` Jakub Kicinski
2020-11-11 3:03 ` tanhuazhong
2020-11-09 3:22 ` [PATCH V2 net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ Huazhong Tan
2020-11-09 3:22 ` [PATCH V2 net-next 11/11] net: hns3: add debugfs support for interrupt coalesce Huazhong Tan
2020-11-11 1:28 ` Jakub Kicinski
2020-11-11 3:16 ` tanhuazhong
2020-11-11 16:15 ` Jakub Kicinski
2020-11-12 0:48 ` tanhuazhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a7805e0-7d13-2b34-f15c-1fc7bda151ed@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®