[PATCH] Change the interrupt from level_low to edge_falling

[PATCH] Change the interrupt from level_low to edge_falling

[Gabriel Tremblay via B4 Relay]

From: Gabriel Tremblay <tremblay.gabriel@gmail.com>



---
Lenovo's x13s internal keyboard shows responsivity issues when fast
typing occurs. The problem is not replicated with external HID keyboard.

This fix tries to alleviate the problem but requires further testing
and commenting.

Signed-off-by: Gabriel Tremblay <tremblay.gabriel@gmail.com>
---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index bdcba719fc38..e8d7f02c9bf3 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -639,7 +639,7 @@ keyboard@68 {
 		reg = <0x68>;
 
 		hid-descr-addr = <0x1>;
-		interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
+		interrupts-extended = <&tlmm 104 IRQ_TYPE_EDGE_FALLING>;
 		vdd-supply = <&vreg_misc_3p3>;
 		vddl-supply = <&vreg_s10b>;
 

---
base-commit: 84e2893b4573da3bc0c9f24e2005442e420e3831
change-id: 20230502-gtremblay-x13s-keyboard-289935f922e2

Best regards,
-- 
Gabriel Tremblay <tremblay.gabriel@gmail.com>

Re: [PATCH] Change the interrupt from level_low to edge_falling

[Caleb Connolly]

On 02/05/2023 19:31, Gabriel Tremblay via B4 Relay wrote:
> From: Gabriel Tremblay <tremblay.gabriel@gmail.com>
> 
> 
> 
> ---
> Lenovo's x13s internal keyboard shows responsivity issues when fast
> typing occurs. The problem is not replicated with external HID keyboard.
> 
> This fix tries to alleviate the problem but requires further testing
> and commenting.
> 
> Signed-off-by: Gabriel Tremblay <tremblay.gabriel@gmail.com>

Hi Gabriel,

Thanks for the patch. Just a small thing to improve: The subject line
should include some reference to which part of the kernel you're
changing as a prefix, so in this case something like:

arm64: dts: qcom: sc8280xp-x13s: use falling edge for keyboard interrupt

might be a more suitable subject line. You can usually look at previous
commits to figure out what the right prefix is, to see commits which
touched a specific file you can do something like this:

$ git log --oneline \
	arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

I don't own an x13s so I can't comment on the change, but hopefully this
is helpful for a v2 or any future patches!

> ---
>  arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index bdcba719fc38..e8d7f02c9bf3 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -639,7 +639,7 @@ keyboard@68 {
>  		reg = <0x68>;
>  
>  		hid-descr-addr = <0x1>;
> -		interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&tlmm 104 IRQ_TYPE_EDGE_FALLING>;
>  		vdd-supply = <&vreg_misc_3p3>;
>  		vddl-supply = <&vreg_s10b>;
>  
> 
> ---
> base-commit: 84e2893b4573da3bc0c9f24e2005442e420e3831
> change-id: 20230502-gtremblay-x13s-keyboard-289935f922e2
> 
> Best regards,

-- 
Kind Regards,
Caleb (they/them)

Re: [PATCH] Change the interrupt from level_low to edge_falling

[Bjorn Andersson]

On Tue, May 02, 2023 at 02:31:14PM -0400, Gabriel Tremblay via B4 Relay wrote:
> From: Gabriel Tremblay <tremblay.gabriel@gmail.com>
> 
> 
> 
> ---
> Lenovo's x13s internal keyboard shows responsivity issues when fast
> typing occurs. The problem is not replicated with external HID keyboard.
> 
> This fix tries to alleviate the problem but requires further testing
> and commenting.
> 

This is interesting, can you tell us a little bit more about why/how
this improves the situation? Perhaps that could help someone with
schematics to look into this further as well.

Regards,
Bjorn

> Signed-off-by: Gabriel Tremblay <tremblay.gabriel@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index bdcba719fc38..e8d7f02c9bf3 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -639,7 +639,7 @@ keyboard@68 {
>  		reg = <0x68>;
>  
>  		hid-descr-addr = <0x1>;
> -		interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&tlmm 104 IRQ_TYPE_EDGE_FALLING>;
>  		vdd-supply = <&vreg_misc_3p3>;
>  		vddl-supply = <&vreg_s10b>;
>  
> 
> ---
> base-commit: 84e2893b4573da3bc0c9f24e2005442e420e3831
> change-id: 20230502-gtremblay-x13s-keyboard-289935f922e2
> 
> Best regards,
> -- 
> Gabriel Tremblay <tremblay.gabriel@gmail.com>
>