* [PATCH] cpuset: remove set but not used variable 'cs'
@ 2018-11-07 7:18 Yi Wang
2018-11-07 22:08 ` Tom Hromatka
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2018-11-07 7:18 UTC (permalink / raw)
To: lizefan; +Cc: cgroups, linux-kernel, zhong.weidong, Yi Wang
This fixes the following warning:
kernel/cgroup/cpuset.c: In function ‘cpuset_cancel_attach’:
kernel/cgroup/cpuset.c:1501:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
struct cpuset *cs;
^
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
---
kernel/cgroup/cpuset.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 266f10c..784f948 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
static void cpuset_cancel_attach(struct cgroup_taskset *tset)
{
struct cgroup_subsys_state *css;
- struct cpuset *cs;
cgroup_taskset_first(tset, &css);
- cs = css_cs(css);
mutex_lock(&cpuset_mutex);
css_cs(css)->attach_in_progress--;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cpuset: remove set but not used variable 'cs'
2018-11-07 7:18 [PATCH] cpuset: remove set but not used variable 'cs' Yi Wang
@ 2018-11-07 22:08 ` Tom Hromatka
0 siblings, 0 replies; 2+ messages in thread
From: Tom Hromatka @ 2018-11-07 22:08 UTC (permalink / raw)
To: Yi Wang, lizefan; +Cc: cgroups, linux-kernel, zhong.weidong
On 11/07/2018 12:18 AM, Yi Wang wrote:
> This fixes the following warning:
> kernel/cgroup/cpuset.c: In function ‘cpuset_cancel_attach’:
> kernel/cgroup/cpuset.c:1501:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
> struct cpuset *cs;
> ^
>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Tom Hromatka <tom.hromatka@oracle.com>
> ---
> kernel/cgroup/cpuset.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 266f10c..784f948 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
> static void cpuset_cancel_attach(struct cgroup_taskset *tset)
> {
> struct cgroup_subsys_state *css;
> - struct cpuset *cs;
>
> cgroup_taskset_first(tset, &css);
> - cs = css_cs(css);
>
> mutex_lock(&cpuset_mutex);
> css_cs(css)->attach_in_progress--;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-07 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 7:18 [PATCH] cpuset: remove set but not used variable 'cs' Yi Wang
2018-11-07 22:08 ` Tom Hromatka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®