* [PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition
[not found] <20230711033745.79190-1-xujianghui@cdjrlc.com>
@ 2023-07-11 3:39 ` sunran001
0 siblings, 0 replies; only message in thread
From: sunran001 @ 2023-07-11 3:39 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, nouveau, linux-kernel
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
index 16b246fda666..52af200b45bc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
@@ -203,7 +203,8 @@ nvkm_falcon_msgq_new(struct nvkm_falcon_qmgr *qmgr,
const char *name,
{
struct nvkm_falcon_msgq *msgq = *pmsgq;
- if (!(msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL)))
+ msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL);
+ if (!msgq)
return -ENOMEM;
msgq->qmgr = qmgr;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-11 3:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230711033745.79190-1-xujianghui@cdjrlc.com>
2023-07-11 3:39 ` [PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition sunran001
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®