From: Sudeep Holla <sudeep.holla@arm.com>
To: Alexey Klimov <alexey.klimov@arm.com>,
jassisinghbrar@gmail.com, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>, jaswinder.singh@linaro.org
Subject: Re: [PATCH] mailbox: check ->last_tx_done for NULL in case of timer-based polling
Date: Tue, 21 Mar 2017 17:03:21 +0000 [thread overview]
Message-ID: <7b0ee7c4-6470-bfe8-1609-79283c4f4de3@arm.com> (raw)
In-Reply-To: <1490115454-32308-1-git-send-email-alexey.klimov@arm.com>
On 21/03/17 16:57, Alexey Klimov wrote:
> It is allowed by code to register mailbox controller that sets txdone_poll
> flag to request timer-based polling with missed ->last_tx_done() method.
> If such thing happens and since presence of last_tx_done() is not checked
> it will fail in hrtimer callback function txdone_hrtimer() when first
> message will be transmitted.
>
> This patch adds check for this method and logging of error on
> registration of mailbox controller if it requested timer-based polling.
>
Good to have check.
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
prev parent reply other threads:[~2017-03-21 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 16:57 Alexey Klimov
2017-03-21 17:03 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b0ee7c4-6470-bfe8-1609-79283c4f4de3@arm.com \
--to=sudeep.holla@arm.com \
--cc=alexey.klimov@arm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®