From: Shuah Khan <skhan@linuxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@collabora.com>,
Shuah Khan <shuah@kernel.org>
Cc: kernel@collabora.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kselftest: Add missing signature to the comments
Date: Thu, 4 Apr 2024 11:06:22 -0600 [thread overview]
Message-ID: <7b7447d8-cf99-4a0a-9510-f4d2d9791264@linuxfoundation.org> (raw)
In-Reply-To: <20240404155511.57502-1-usama.anjum@collabora.com>
On 4/4/24 09:55, Muhammad Usama Anjum wrote:
> The comment on top of the file is used by many developers to glance over
> all the available functions. Add the recently added ksft_perror() to it.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/kselftest.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index 7d650a06ca359..159bf8e314fa3 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -16,6 +16,7 @@
> * For each test, report any progress, debugging, etc with:
> *
> * ksft_print_msg(fmt, ...);
> + * ksft_perror(msg);
> *
> * and finally report the pass/fail/skip/xfail state of the test with one of:
> *
Thank you. Applied to linux-kselftest next for Linux 6.10-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2024-04-04 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 15:55 Muhammad Usama Anjum
2024-04-04 17:06 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7447d8-cf99-4a0a-9510-f4d2d9791264@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®