mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] kselftest: Add missing signature to the comments
@ 2024-04-04 15:55 Muhammad Usama Anjum
  2024-04-04 17:06 ` Shuah Khan
  0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Usama Anjum @ 2024-04-04 15:55 UTC (permalink / raw)
  To: Shuah Khan; +Cc: Muhammad Usama Anjum, kernel, linux-kselftest, linux-kernel

The comment on top of the file is used by many developers to glance over
all the available functions. Add the recently added ksft_perror() to it.

Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/kselftest.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 7d650a06ca359..159bf8e314fa3 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -16,6 +16,7 @@
  * For each test, report any progress, debugging, etc with:
  *
  *     ksft_print_msg(fmt, ...);
+ *     ksft_perror(msg);
  *
  * and finally report the pass/fail/skip/xfail state of the test with one of:
  *
-- 
2.39.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kselftest: Add missing signature to the comments
  2024-04-04 15:55 [PATCH] kselftest: Add missing signature to the comments Muhammad Usama Anjum
@ 2024-04-04 17:06 ` Shuah Khan
  0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-04-04 17:06 UTC (permalink / raw)
  To: Muhammad Usama Anjum, Shuah Khan
  Cc: kernel, linux-kselftest, linux-kernel, Shuah Khan

On 4/4/24 09:55, Muhammad Usama Anjum wrote:
> The comment on top of the file is used by many developers to glance over
> all the available functions. Add the recently added ksft_perror() to it.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>   tools/testing/selftests/kselftest.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index 7d650a06ca359..159bf8e314fa3 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -16,6 +16,7 @@
>    * For each test, report any progress, debugging, etc with:
>    *
>    *     ksft_print_msg(fmt, ...);
> + *     ksft_perror(msg);
>    *
>    * and finally report the pass/fail/skip/xfail state of the test with one of:
>    *

Thank you. Applied to linux-kselftest next for Linux 6.10-rc1

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-04 17:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-04 15:55 [PATCH] kselftest: Add missing signature to the comments Muhammad Usama Anjum
2024-04-04 17:06 ` Shuah Khan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®