From: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Sebastian Reichel <sre@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Srinivas Kandagatla <srini@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-watchdog@vger.kernel.org, linux-arm-msm@vger.org,
kernel@pengutronix.de, avaneesh.dwivedi@oss.qualcomm.com,
Umang Chheda <umang.chheda@oss.qualcomm.com>
Subject: Re: [PATCH 2/2] watchdog: pscrr: add watchdog pretimeout reason tracking
Date: Tue, 21 Jul 2026 16:35:04 +0530 [thread overview]
Message-ID: <7b74e6de-fa0f-493c-a159-56bfb0c7de4a@oss.qualcomm.com> (raw)
In-Reply-To: <5c824be9-59d8-4acb-a2a3-784182ba3c8c@roeck-us.net>
Hi Guenter,
On 20-Jul-26 10:09 PM, Guenter Roeck wrote:
> On Tue, Jul 14, 2026 at 03:22:35PM +0530, Faruque Ansari wrote:
>> A watchdog pretimeout fires before the actual reset, giving the kernel
>> a brief window to record what happened. Without this change that
>> window goes unused and the next boot sees PSCR_UNKNOWN, making it
>> impossible to tell a watchdog-driven reset from any other cause.
>>
>> Call set_psc_reason(PSCR_WATCHDOG_PRETIMEOUT) at the top of
>> watchdog_notify_pretimeout() so the reason is recorded as soon as the
>> pretimeout is signalled, before any governor action runs.
>>
>> Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
>> ---
>> drivers/power/reset/pscrr.c | 3 ++-
>> drivers/watchdog/watchdog_pretimeout.c | 3 +++
>> include/linux/power/power_on_reason.h | 1 +
>> include/linux/reboot.h | 1 +
>> kernel/reboot.c | 1 +
>
> This is a cross-subsystem change. As far as I can see it would
> be easy to split it into two patches. Please do that.
>
> Guenter
>
Thanks for taking the time to review this.
I'll split into separate PSCRR and watchdog patches in v2.
Thanks,
Faruque Ansari
next prev parent reply other threads:[~2026-07-21 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:52 [PATCH 0/2] power: reset: pscrr: record reset cause on panic and watchdog pretimeout Faruque Ansari
2026-07-14 9:52 ` [PATCH 1/2] power: reset: pscrr: add kernel panic reason tracking Faruque Ansari
2026-07-14 9:52 ` [PATCH 2/2] watchdog: pscrr: add watchdog pretimeout " Faruque Ansari
2026-07-20 16:39 ` Guenter Roeck
2026-07-21 11:05 ` Faruque Ansari [this message]
2026-07-15 6:20 ` [PATCH 0/2] power: reset: pscrr: record reset cause on panic and watchdog pretimeout Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b74e6de-fa0f-493c-a159-56bfb0c7de4a@oss.qualcomm.com \
--to=faruque.ansari@oss.qualcomm.com \
--cc=avaneesh.dwivedi@oss.qualcomm.com \
--cc=bleung@chromium.org \
--cc=daniel.lezcano@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-msm@vger.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=o.rempel@pengutronix.de \
--cc=sre@kernel.org \
--cc=srini@kernel.org \
--cc=tzungbi@kernel.org \
--cc=umang.chheda@oss.qualcomm.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®