From: Pavel Skripkin <paskripkin@gmail.com>
To: Vihas Makwana <makvihas@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl
Date: Mon, 16 May 2022 22:45:20 +0300 [thread overview]
Message-ID: <7b926f43-8c6b-6eae-edc6-02dc16376eb0@gmail.com> (raw)
In-Reply-To: <20220516170306.6008-3-makvihas@gmail.com>
Hi Vihas,
On 5/16/22 20:03, Vihas Makwana wrote:
> Refactor the code to fix following warnings:
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Vihas Makwana <makvihas@gmail.com>
> ---
[code snip]
> if ((pwrpriv->smart_ps == smart_ps) &&
> @@ -356,7 +356,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
>
> pwrctrlpriv->LpsIdleCount = 0;
> pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/* PS_MODE_MIN; */
> - pwrctrlpriv->bLeisurePs = PS_MODE_ACTIVE != pwrctrlpriv->power_mgnt;
> + pwrctrlpriv->bLeisurePs = pwrctrlpriv->power_mgnt != PS_MODE_ACTIVE;
>
Please remove extra space
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-05-16 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 17:03 [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings Vihas Makwana
2022-05-16 17:03 ` [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p Vihas Makwana
2022-05-16 17:03 ` [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl Vihas Makwana
2022-05-16 19:45 ` Pavel Skripkin [this message]
2022-05-17 13:51 ` Vihas Makwana
2022-05-16 17:03 ` [PATCH 3/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_wlan_util Vihas Makwana
2022-05-16 19:49 ` [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b926f43-8c6b-6eae-edc6-02dc16376eb0@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®