From: Pavel Skripkin <paskripkin@gmail.com>
To: Vihas Makwana <makvihas@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 0/3] staging: r8188eu: fix checkpatch.pl warnings
Date: Mon, 16 May 2022 22:49:50 +0300 [thread overview]
Message-ID: <8142ad15-1fdc-10f8-86f2-fb275cb6cd39@gmail.com> (raw)
In-Reply-To: <20220516170306.6008-1-makvihas@gmail.com>
Hi Vihas,
On 5/16/22 20:03, Vihas Makwana wrote:
> This patchset fixes following checkpatch warning:
> WARNING: Comparisons should place the constant on the right side of the test
>
> Compiled tested only.
>
> Vihas Makwana (3):
> staging: r8188eu: fix checkpatch warnings in rtw_p2p
> staging: r8188eu: fix checkpatch warnings in rtw_pwrctrl
> staging: r8188eu: fix checkpatch warnings in rtw_wlan_util
>
> drivers/staging/r8188eu/core/rtw_p2p.c | 8 ++++----
> drivers/staging/r8188eu/core/rtw_pwrctrl.c | 12 ++++++------
> drivers/staging/r8188eu/core/rtw_wlan_util.c | 2 +-
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
checkpatch warns about the subjects. See an example for 1/3, but it's
related to all 3.
> WARNING: A patch subject line should describe the change not the tool that found it
> #4:
> Subject: [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p
>
> total: 0 errors, 1 warnings, 0 checks, 32 lines checked
With regards,
Pavel Skripkin
prev parent reply other threads:[~2022-05-16 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 17:03 Vihas Makwana
2022-05-16 17:03 ` [PATCH 1/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_p2p Vihas Makwana
2022-05-16 17:03 ` [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl Vihas Makwana
2022-05-16 19:45 ` Pavel Skripkin
2022-05-17 13:51 ` Vihas Makwana
2022-05-16 17:03 ` [PATCH 3/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_wlan_util Vihas Makwana
2022-05-16 19:49 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8142ad15-1fdc-10f8-86f2-fb275cb6cd39@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=makvihas@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®