mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next] net: stmmac: dwmac-sun8i: Defer probe when the EPHY clock is not ready
@ 2026-11-13  8:04 Arun Iyengar via B4 Relay
  2026-11-17  8:13 ` netdev-bot+sashiko
  0 siblings, 1 reply; 3+ messages in thread
From: Arun Iyengar via B4 Relay @ 2026-11-13  8:04 UTC (permalink / raw)
  To: Maxime Chevallier, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Maxime Coquelin, Alexandre Torgue,
	Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Corentin Labbe
  Cc: netdev, linux-stm32, linux-arm-kernel, linux-sunxi, linux-kernel,
	Arun Iyengar

From: Arun Iyengar <aiyengar1990@gmail.com>

get_ephy_nodes() skips an internal PHY node on any of_clk_get() error.
If the EPHY clock provider is not registered yet, the node is skipped,
the function returns -ENODEV and the probe fails for good. The reset
lookup right below already returns -EPROBE_DEFER in this case.

Return -EPROBE_DEFER for the clock too. Other clock errors still skip
the node, as before.

Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
---
Reported by the Sashiko review bot while it reviewed my MDIO mux error
path fix for this driver:
https://sashiko.dev/#/bug/linux-98384c14-541e-410e-a074-fff5e98b3820

Only the H3/H5 and V3s variants (soc_has_internal_phy) reach this code.
With the in-tree device trees the EPHY clock comes from the same CCU as
the EMAC clock and reset, so the EMAC probe already waits for that CCU
and this cannot fail there. It matters when the EPHY clock comes
from a provider that probes later. Build-tested only (W=1, arm64 and
arm); I have no board with the internal PHY.

This patch was developed with Claude (Anthropic) as a coding assistant:
it checked the report against the code and wrote the fix and the commit
message. I reviewed it.
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
index 2ece7ba9dd73..8163e49fa7ad 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
@@ -801,8 +801,13 @@ static int get_ephy_nodes(struct stmmac_priv *priv)
 		struct clk *ephy_clk;
 
 		ephy_clk = of_clk_get(iphynode, 0);
-		if (IS_ERR(ephy_clk))
+		if (IS_ERR(ephy_clk)) {
+			if (PTR_ERR(ephy_clk) == -EPROBE_DEFER) {
+				of_node_put(mdio_internal);
+				return -EPROBE_DEFER;
+			}
 			continue;
+		}
 		gmac->rst_ephy = of_reset_control_get_exclusive(iphynode, NULL);
 		if (IS_ERR(gmac->rst_ephy)) {
 			ret = PTR_ERR(gmac->rst_ephy);

---
base-commit: 573af801552999954caa8347e4490b04cf4763f0
change-id: 20261113-b4-sun8i-emac-ephy-defer-480c39394e6a

Best regards,
--  
Arun Iyengar <aiyengar1990@gmail.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-17  9:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-13  8:04 [PATCH net-next] net: stmmac: dwmac-sun8i: Defer probe when the EPHY clock is not ready Arun Iyengar via B4 Relay
2026-11-17  8:13 ` netdev-bot+sashiko
2026-11-17  9:35   ` Maxime Chevallier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®