From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Taniya Das <quic_tdas@quicinc.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Abhishek Sahu <absahu@codeaurora.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver
Date: Fri, 1 Nov 2024 12:29:25 +0000 [thread overview]
Message-ID: <7be231c6-a5b6-41ec-b43d-cbba07e7c448@linaro.org> (raw)
In-Reply-To: <20241101-qcs615-mm-clockcontroller-v2-4-d1a4870a4aed@quicinc.com>
On 01/11/2024 10:38, Taniya Das wrote:
> + .vco_val = 0x2 << 20,
vco_val = BIT(21)
> + .vco_mask = 0x3 << 20,
Instead of bit shifting couldn't we just use GENMASK ?
Aside from anything else shifting a hex value by a decimal value isn't
the clearest code in the world.
vco_mask = GENMASK(21, 20)
Much cleaner.
drivers/clk/qcom/gcc-sm6115.c
Same comment for all of the bit-shifts in the series, I appreciate the
shifts are what the downstream code does but BIT/GENMASK does this job
better.
Once fixed you can add my
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
to this file
---
bod
next prev parent reply other threads:[~2024-11-01 12:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 10:38 [PATCH v2 00/11] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform Taniya Das
2024-11-01 10:38 ` [PATCH v2 01/11] clk: qcom: Update the support for alpha mode configuration Taniya Das
2024-11-01 10:38 ` [PATCH v2 02/11] clk: qcom: clk-alpha-pll: Add support for dynamic update for slewing PLLs Taniya Das
2024-11-07 10:05 ` Imran Shaik
2024-11-01 10:38 ` [PATCH v2 03/11] dt-bindings: clock: Add Qualcomm QCS615 Camera clock controller Taniya Das
2024-11-02 13:02 ` Krzysztof Kozlowski
2024-11-01 10:38 ` [PATCH v2 04/11] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver Taniya Das
2024-11-01 12:29 ` Bryan O'Donoghue [this message]
2024-11-08 4:00 ` Taniya Das
2024-11-01 10:38 ` [PATCH v2 05/11] dt-bindings: clock: Add Qualcomm QCS615 Display clock controller Taniya Das
2024-11-01 11:42 ` Rob Herring (Arm)
2024-11-01 10:38 ` [PATCH v2 06/11] clk: qcom: dispcc-qcs615: Add QCS615 display clock controller driver Taniya Das
2024-11-01 10:38 ` [PATCH v2 07/11] dt-bindings: clock: Add Qualcomm QCS615 Graphics clock controller Taniya Das
2024-11-01 11:42 ` Rob Herring (Arm)
2024-11-01 10:38 ` [PATCH v2 08/11] clk: qcom: gpucc-qcs615: Add QCS615 graphics clock controller driver Taniya Das
2024-11-01 10:38 ` [PATCH v2 09/11] dt-bindings: clock: Add Qualcomm QCS615 Video clock controller Taniya Das
2024-11-01 11:42 ` Rob Herring (Arm)
2024-11-01 10:38 ` [PATCH v2 10/11] clk: qcom: videocc-qcs615: Add QCS615 video clock controller driver Taniya Das
2024-11-01 10:38 ` [PATCH v2 11/11] arm64: defconfig: Enable QCS615 clock controllers Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7be231c6-a5b6-41ec-b43d-cbba07e7c448@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=absahu@codeaurora.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®