mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Mehta Sanju <Sanju.Mehta@amd.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices
Date: Tue, 11 Oct 2022 16:16:25 +0300	[thread overview]
Message-ID: <7c08c4c8-562d-553f-e513-c925080300a7@linux.intel.com> (raw)
In-Reply-To: <Y0T68lC6bUY7dg7D@black.fi.intel.com>

On 11.10.2022 8.11, Mika Westerberg wrote:
> On Mon, Oct 10, 2022 at 11:00:21AM -0500, Mario Limonciello wrote:
>> For optimal power consumption of USB4 routers the XHCI PCIe endpoint
>> used for tunneling must be in D3.  Historically this is accomplished
>> by a long list of PCIe IDs that correspond to these endpoints because
>> the xhci_hcd driver will not default to allowing runtime PM for all
>> devices.
>>
>> As both AMD and Intel have released new products with new XHCI controllers
>> this list continues to grow. In reviewing the XHCI specification v1.2 on
>> page 607 there is already a requirement that the PCI power management
>> states D3hot and D3cold must be supported.
>>
>> In the quirk list, use this to indicate that runtime PM should be allowed
>> on XHCI controllers. The following controllers are known to be xHC 1.2 and
>> dropped explicitly:
>> * AMD Yellow Carp
>> * Intel Alder Lake
>> * Intel Meteor Lake
>> * Intel Raptor Lake
>>
>> Suggested-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>> Link: https://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/extensible-host-controler-interface-usb-xhci.pdf
>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks, added to queue

-Mathias

  reply	other threads:[~2022-10-11 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 16:00 Mario Limonciello
2022-10-11  5:11 ` Mika Westerberg
2022-10-11 13:16   ` Mathias Nyman [this message]
2022-10-11 16:46     ` Limonciello, Mario
2022-10-12  8:34       ` Mathias Nyman
2022-10-12 12:59         ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c08c4c8-562d-553f-e513-c925080300a7@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=Sanju.Mehta@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mathias.nyman@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome