* [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2
@ 2025-12-24 10:45 Abel Vesa
2025-12-24 10:45 ` [PATCH v3 1/3] dt-bindings: watchdog: Document X1E80100 compatible Abel Vesa
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Abel Vesa @ 2025-12-24 10:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Abel Vesa, Dmitry Baryshkov
On X1E80100 platforms, in EL2, the APSS watchdog is accessible.
The APSS WDT HW is compatible with the one from SC8280XP, SM8250 and the
like. So describe it in the SoC dtsi, mark it as reserved and enable it
the EL2 overlay. Also document its compatible.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v3:
- Change the comment for the reserved status in the SoC dtsi node
according to Konrad's suggestion.
- Picked up Rob's R-b tag and Guenter's A-b tag for the bindings patch
- Picked up Dmitry's R-b tag for the dtso patch
- Link to v2: https://patch.msgid.link/20251219-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v2-0-fdfc6ba663e6@oss.qualcomm.com
Changes in v2:
- Moved the node in the SoC dtsi and marked it as reserved.
This allowed dropping the interrupt-parent property.
As suggested by Stephan.
- Added separate patch to enable the node in EL2 overlay.
- Picked up Rob's R-b patch for bindings patch..
- Link to v1: https://patch.msgid.link/20251214-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-v1-0-94ee80b8cbe7@oss.qualcomm.com
---
Abel Vesa (3):
dt-bindings: watchdog: Document X1E80100 compatible
arm64: dts: qcom: hamoa: Add the APSS watchdog
arm64: dts: qcom: x1-el2: Enable the APSS watchdog
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
arch/arm64/boot/dts/qcom/hamoa.dtsi | 8 ++++++++
arch/arm64/boot/dts/qcom/x1-el2.dtso | 4 ++++
3 files changed, 13 insertions(+)
---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20251214-arm64-dts-qcom-x1e80100-el2-add-apss-wdt-e04ca6c99f0f
Best regards,
--
Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/3] dt-bindings: watchdog: Document X1E80100 compatible
2025-12-24 10:45 [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
@ 2025-12-24 10:45 ` Abel Vesa
2025-12-24 10:45 ` [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Abel Vesa @ 2025-12-24 10:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Abel Vesa
Document the compatible for the X1E80100 platform to the Qualcomm watchdog
binding. The HW implementation is compatible with the KPSS WDT.
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 54f5311ed016..f2c4bc900e5f 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -43,6 +43,7 @@ properties:
- qcom,apss-wdt-sm6350
- qcom,apss-wdt-sm8150
- qcom,apss-wdt-sm8250
+ - qcom,apss-wdt-x1e80100
- const: qcom,kpss-wdt
- const: qcom,kpss-wdt
deprecated: true
--
2.48.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog
2025-12-24 10:45 [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
2025-12-24 10:45 ` [PATCH v3 1/3] dt-bindings: watchdog: Document X1E80100 compatible Abel Vesa
@ 2025-12-24 10:45 ` Abel Vesa
2025-12-24 12:23 ` Dmitry Baryshkov
2025-12-29 11:48 ` Konrad Dybcio
2025-12-24 10:45 ` [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable " Abel Vesa
2026-01-21 2:35 ` [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Bjorn Andersson
3 siblings, 2 replies; 8+ messages in thread
From: Abel Vesa @ 2025-12-24 10:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Abel Vesa
The watchdog support in EL1 is SBSA compliant, handled by Gunyah
hypervisor, but in EL2. the watchdog is an instance of the APSS WDT HW
block, same as older platforms. So describe the APSS WDT node and mark
it as reserved, as it will only be enabled in EL2 overlay.
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/hamoa.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi
index bb7c14d473c9..7a1f7e6860df 100644
--- a/arch/arm64/boot/dts/qcom/hamoa.dtsi
+++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi
@@ -8328,6 +8328,14 @@ gic_its: msi-controller@17040000 {
};
};
+ apss_watchdog: watchdog@17410000 {
+ compatible = "qcom,apss-wdt-x1e80100", "qcom,kpss-wdt";
+ reg = <0x0 0x17410000 0x0 0x1000>;
+ clocks = <&sleep_clk>;
+ interrupts = <GIC_SPI 0 IRQ_TYPE_EDGE_RISING>;
+ status = "reserved"; /* Reserved by Gunyah */
+ };
+
cpucp_mbox: mailbox@17430000 {
compatible = "qcom,x1e80100-cpucp-mbox";
reg = <0 0x17430000 0 0x10000>, <0 0x18830000 0 0x10000>;
--
2.48.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable the APSS watchdog
2025-12-24 10:45 [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
2025-12-24 10:45 ` [PATCH v3 1/3] dt-bindings: watchdog: Document X1E80100 compatible Abel Vesa
2025-12-24 10:45 ` [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
@ 2025-12-24 10:45 ` Abel Vesa
2025-12-29 11:48 ` Konrad Dybcio
2026-01-21 2:35 ` [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Bjorn Andersson
3 siblings, 1 reply; 8+ messages in thread
From: Abel Vesa @ 2025-12-24 10:45 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Abel Vesa, Dmitry Baryshkov
In EL2, the APSS watchdog is available. So enable it in the overlay.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/x1-el2.dtso | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1-el2.dtso b/arch/arm64/boot/dts/qcom/x1-el2.dtso
index 2d1c9151cf1b..175679be01eb 100644
--- a/arch/arm64/boot/dts/qcom/x1-el2.dtso
+++ b/arch/arm64/boot/dts/qcom/x1-el2.dtso
@@ -7,6 +7,10 @@
/dts-v1/;
/plugin/;
+&apss_watchdog {
+ status = "okay";
+};
+
/* We can't and don't need to use zap shader in EL2 as linux can zap the gpu on it's own. */
&gpu_zap_shader {
status = "disabled";
--
2.48.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog
2025-12-24 10:45 ` [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
@ 2025-12-24 12:23 ` Dmitry Baryshkov
2025-12-29 11:48 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2025-12-24 12:23 UTC (permalink / raw)
To: Abel Vesa
Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio, Stephan Gerhold, linux-arm-msm,
linux-watchdog, devicetree, linux-kernel
On Wed, Dec 24, 2025 at 12:45:21PM +0200, Abel Vesa wrote:
> The watchdog support in EL1 is SBSA compliant, handled by Gunyah
> hypervisor, but in EL2. the watchdog is an instance of the APSS WDT HW
> block, same as older platforms. So describe the APSS WDT node and mark
> it as reserved, as it will only be enabled in EL2 overlay.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/hamoa.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog
2025-12-24 10:45 ` [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
2025-12-24 12:23 ` Dmitry Baryshkov
@ 2025-12-29 11:48 ` Konrad Dybcio
1 sibling, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-12-29 11:48 UTC (permalink / raw)
To: Abel Vesa, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree, linux-kernel
On 12/24/25 11:45 AM, Abel Vesa wrote:
> The watchdog support in EL1 is SBSA compliant, handled by Gunyah
> hypervisor, but in EL2. the watchdog is an instance of the APSS WDT HW
> block, same as older platforms. So describe the APSS WDT node and mark
> it as reserved, as it will only be enabled in EL2 overlay.
>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable the APSS watchdog
2025-12-24 10:45 ` [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable " Abel Vesa
@ 2025-12-29 11:48 ` Konrad Dybcio
0 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2025-12-29 11:48 UTC (permalink / raw)
To: Abel Vesa, Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak,
Bjorn Andersson, Konrad Dybcio
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Dmitry Baryshkov
On 12/24/25 11:45 AM, Abel Vesa wrote:
> In EL2, the APSS watchdog is available. So enable it in the overlay.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2
2025-12-24 10:45 [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
` (2 preceding siblings ...)
2025-12-24 10:45 ` [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable " Abel Vesa
@ 2026-01-21 2:35 ` Bjorn Andersson
3 siblings, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2026-01-21 2:35 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Rajendra Nayak, Konrad Dybcio,
Abel Vesa
Cc: Stephan Gerhold, linux-arm-msm, linux-watchdog, devicetree,
linux-kernel, Dmitry Baryshkov
On Wed, 24 Dec 2025 12:45:19 +0200, Abel Vesa wrote:
> On X1E80100 platforms, in EL2, the APSS watchdog is accessible.
> The APSS WDT HW is compatible with the one from SC8280XP, SM8250 and the
> like. So describe it in the SoC dtsi, mark it as reserved and enable it
> the EL2 overlay. Also document its compatible.
>
>
Applied, thanks!
[1/3] dt-bindings: watchdog: Document X1E80100 compatible
commit: 6609c1976e64b6ce31fc2de11136dd7703372f20
[2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog
commit: 4da4883613f62d4d60ada443d09ac36644f27d8a
[3/3] arm64: dts: qcom: x1-el2: Enable the APSS watchdog
commit: f010e0b997035d82586e32e3427d88ef76edb3cb
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-01-21 2:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-24 10:45 [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Abel Vesa
2025-12-24 10:45 ` [PATCH v3 1/3] dt-bindings: watchdog: Document X1E80100 compatible Abel Vesa
2025-12-24 10:45 ` [PATCH v3 2/3] arm64: dts: qcom: hamoa: Add the APSS watchdog Abel Vesa
2025-12-24 12:23 ` Dmitry Baryshkov
2025-12-29 11:48 ` Konrad Dybcio
2025-12-24 10:45 ` [PATCH v3 3/3] arm64: dts: qcom: x1-el2: Enable " Abel Vesa
2025-12-29 11:48 ` Konrad Dybcio
2026-01-21 2:35 ` [PATCH v3 0/3] arm64: dts: qcom: x1e80100: Enable APSS watchdog in EL2 Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®