mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jacob Pyke <jacob@pyk.ee>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: neil.armstrong@linaro.org, jesszhan0024@gmail.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, teguh@sobir.in,
	Andrew.liu@moorechip.net
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Retroid Pocket IL97680A panels
Date: Thu, 29 Oct 2026 14:07:49 +1000	[thread overview]
Message-ID: <7c3464b0-db2c-4554-a055-4add944818f7@pyk.ee> (raw)
In-Reply-To: <20261027-inventive-hidden-ostrich-66dfac@quoll>

> Please do not reference random 3rd party repositories for no reason.

> Drop tag

> Keep the entire allOf just before additionalProperties: block.

No worries, will address these in V2

> I would expect IL97680A fallback compatible.

I'll add a "ilitek,il97680a" after each panel-specific compatible and update the examples in V2

Thanks for the review. First submission so still learning the ropes. Appreciate the patience.

Thanks,
Jacob

  reply	other threads:[~2026-10-29  4:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 13:37 [PATCH 0/2] drm/panel: Add IL97680A panels for Retroid Pocket Nova and Duo Jacob Pyke
2026-10-25 13:37 ` [PATCH 1/2] dt-bindings: display: panel: Add Retroid Pocket IL97680A panels Jacob Pyke
2026-10-27  8:22   ` Krzysztof Kozlowski
2026-10-29  4:07     ` Jacob Pyke [this message]
2026-10-25 13:37 ` [PATCH 2/2] drm/panel: Add Ilitek IL97680A panels for Retroid Pocket Nova and Duo Jacob Pyke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c3464b0-db2c-4554-a055-4add944818f7@pyk.ee \
    --to=jacob@pyk.ee \
    --cc=Andrew.liu@moorechip.net \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=teguh@sobir.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®