From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Russell King <linux@armlinux.org.uk>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
Date: Wed, 10 Apr 2024 17:20:15 +0200 [thread overview]
Message-ID: <7c612f63-fd7d-4f5a-ace6-05b2bc29f3eb@linaro.org> (raw)
In-Reply-To: <20240410082218.46525-1-krzysztof.kozlowski@linaro.org>
On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Resent third time
> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/gpu/drm/armada/armada_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index e51ecc4f7ef4..f48e2cf8de43 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
> MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
> MODULE_DESCRIPTION("Armada DRM Driver");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:armada-drm");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
I think we'll need maxime or thomas ack to apply this via drm-misc-next
Neil
next prev parent reply other threads:[~2024-04-10 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 8:22 Krzysztof Kozlowski
2024-04-10 15:20 ` Neil Armstrong [this message]
2024-04-11 7:01 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c612f63-fd7d-4f5a-ace6-05b2bc29f3eb@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®