* [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
@ 2024-04-10 8:22 Krzysztof Kozlowski
2024-04-10 15:20 ` Neil Armstrong
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-10 8:22 UTC (permalink / raw)
To: Russell King, David Airlie, Daniel Vetter, dri-devel, linux-kernel
Cc: Krzysztof Kozlowski, Dmitry Baryshkov, Neil Armstrong
The MODULE_DEVICE_TABLE already creates proper alias for platform
driver. Having another MODULE_ALIAS causes the alias to be duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Resent third time
https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/gpu/drm/armada/armada_drv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
index e51ecc4f7ef4..f48e2cf8de43 100644
--- a/drivers/gpu/drm/armada/armada_drv.c
+++ b/drivers/gpu/drm/armada/armada_drv.c
@@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
MODULE_DESCRIPTION("Armada DRM Driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:armada-drm");
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
2024-04-10 8:22 [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
@ 2024-04-10 15:20 ` Neil Armstrong
2024-04-11 7:01 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2024-04-10 15:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, Russell King, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Cc: Dmitry Baryshkov
On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Resent third time
> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> drivers/gpu/drm/armada/armada_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
> index e51ecc4f7ef4..f48e2cf8de43 100644
> --- a/drivers/gpu/drm/armada/armada_drv.c
> +++ b/drivers/gpu/drm/armada/armada_drv.c
> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
> MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
> MODULE_DESCRIPTION("Armada DRM Driver");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:armada-drm");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
I think we'll need maxime or thomas ack to apply this via drm-misc-next
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
2024-04-10 15:20 ` Neil Armstrong
@ 2024-04-11 7:01 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2024-04-11 7:01 UTC (permalink / raw)
To: neil.armstrong, Krzysztof Kozlowski, Russell King, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Cc: Dmitry Baryshkov
Neil Armstrong <neil.armstrong@linaro.org> writes:
Hello Neal,
> On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
>> The MODULE_DEVICE_TABLE already creates proper alias for platform
>> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Resent third time
>> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
>>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> drivers/gpu/drm/armada/armada_drv.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
>> index e51ecc4f7ef4..f48e2cf8de43 100644
>> --- a/drivers/gpu/drm/armada/armada_drv.c
>> +++ b/drivers/gpu/drm/armada/armada_drv.c
>> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
>> MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
>> MODULE_DESCRIPTION("Armada DRM Driver");
>> MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:armada-drm");
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> I think we'll need maxime or thomas ack to apply this via drm-misc-next
>
I don't think you need an explicit ack for them to commit it:
https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#merge-criteria
BTW, the patch looks good to me as well.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-11 7:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-10 8:22 [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS Krzysztof Kozlowski
2024-04-10 15:20 ` Neil Armstrong
2024-04-11 7:01 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®