Re: [abaci-bugfix@linux.alibaba.com: [PATCH] s390: Simplify the calculation of variables]

Re: [abaci-bugfix@linux.alibaba.com: [PATCH] s390: Simplify the calculation of variables]

[Vineeth Vijayan]

> Date: Tue, 26 Jan 2021 17:09:12 +0800
> From: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> To: hca@linux.ibm.com
> Cc: , Jiapeng Zhong
> 	<abaci-bugfix@linux.alibaba.com>
> Subject: [PATCH] s390: Simplify the calculation of variables
> Message-Id: <1611652152-58139-1-git-send-email-abaci-bugfix@linux.alibaba.com>
> X-Mailer: git-send-email 1.8.3.1
>
> Fix the following coccicheck warnings:
>
> ./arch/s390/include/asm/scsw.h:528:48-50: WARNING !A || A && B is
> equivalent to !A || B.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
>   arch/s390/include/asm/scsw.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/include/asm/scsw.h b/arch/s390/include/asm/scsw.h
> index c00f7b0..a7c3ccf 100644
> --- a/arch/s390/include/asm/scsw.h
> +++ b/arch/s390/include/asm/scsw.h
> @@ -525,8 +525,7 @@ static inline int scsw_cmd_is_valid_pno(union scsw *scsw)
>   	return (scsw->cmd.fctl != 0) &&
>   	       (scsw->cmd.stctl & SCSW_STCTL_STATUS_PEND) &&
>   	       (!(scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) ||
> -		 ((scsw->cmd.stctl & SCSW_STCTL_INTER_STATUS) &&
> -		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED)));
> +		  (scsw->cmd.actl & SCSW_ACTL_SUSPENDED));
>   }
>   
>   /**

Thank you.

Reviewed-by: Vineeth Vijayan <vneethv@linux.ibm.com>

this will go via next s390-tree upstream-release.

Regards
Vineeth Vijayan.